[HOLD for payment 2023-09-27] [$1000] After deleting a mobile contact from a WorkSpace, it starts showing up in contacts as @expensify.sms

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Log in with any of your logins
3. Create a new workspace or open an existing one
4. Open the workspace & click on "Members"
5. Click on 'Invite' button
6. Search for an invalid phone number (+2523234211)
7. Select the user > click on "Next" > click on "Invite"
8. Select the user & click on the "Remove" button
9. Click on 'Invite' button

Expected Result:

The previously added contact should appear as a phone number, without the @expensify.sms termination

Actual Result:

A previously added contact is displayed as a phone number with @expensify.sms at the end

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.58-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6180252_Recording__119.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b0b1a782b2526c6
• Upwork Job ID: 1696345977519468544
• Last Price Increase: 2023-08-29
• Automatic offers:
• mollfpr | Reviewer | 26454047
• pradeepmdk | Contributor | 26454050

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a phone contact from WS, it starts showing up in contacts as @expensify.sms in the invite page.

What is the root cause of that problem?

We are not formatting the @expensify.sms text anywhere for invite page.

What changes do you think we should make in order to solve the problem?

We can remove the sms domain in CheckboxListItem with formatPhoneNumber of LocalePhoneNumber by importing like this

import * as LocalePhoneNumber from '../../libs/LocalePhoneNumber';

and update this

{LocalePhoneNumber.formatPhoneNumber(item.text)}

at

App/src/components/SelectionList/CheckboxListItem.js

Line 69 in d42967a

{item.text}

We can wrap the alternate text as well with this similar to the getParticipantsOptions of the OptionLisUtils
if we want to avoid it in cases for alternate text as well just to be safe but presently alternateText has no @expensify.sms portion to be removed.

App/src/components/SelectionList/CheckboxListItem.js

Line 76 in d42967a

{item.alternateText}

{LocalePhoneNumber.formatPhoneNumber(item.alternateText)}

What alternative solutions did you explore? (Optional)

Solution 1
We can instead format the text directly in the OptionListUtils function formatMemberForList here

App/src/libs/OptionsListUtils.js

Line 1047 in a5ab459

text: lodashGet(member, 'text', '') || lodashGet(member, 'displayName', ''),

with LocalePhoneNumber.formatPhoneNumber
and do it similarly for alternateText, name in Avatar if necessary.
This formatMemberForList function is used only for invite page and presently we are not showing any tooltip for CheckboxItem so this solution and the primary solution has no difference. But if we like to show tooltip later, then we need to remove .sms from the name of the tooltip as well. If and when tooltip is implemented, the text there need to be formatted again if we implement the first solution.
This solution is also preferable because the function is meant to format and the phone number formatting logic also is better to be implemented in this.

Solution 2 (too big a refactor for this bug)
Use the getParticipantOptions (because this function has already proper phone number formatting logic) of OptionListUtils to get participant details in workspace members and invite pages instead of individually formatting in the page itself (as done in members page) or each with formatMemberForList (in contacts page) and use the regular logic of using icons object with MultipleAvatars component to show Avatar and tooltips as earlier in CheckboxListItem.

[jliexpensify]

Confirmed that we shouldn't show @expensify.sms anywhere

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b0b1a782b2526c6

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)