[HOLD for payment 2023-09-18] [$1000] Android App - The resizing icon doesn't disappear immediately after sending the message

@mejed-alkoutaini

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

1- Open a chat
2- write multi lines message
3- Click on the send icon

Expected Result:

The resizing icon should disappear immediately after sending the message

Actual Result:

The resizing icon doesn't disappear immediately after sending the message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230815-214619.mp4

Screen.Recording.20230825.231813.New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: @mejed-alkoutaini

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692125347899059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0183904df145af1e22
Upwork Job ID: 1696574863441436672
Last Price Increase: 2023-09-05
Automatic offers:

fedirjh | Reviewer | 26545129
mejed-alkoutaini | Reporter | 26545130

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@zanyrenney

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

Triaged!

Job added to Upwork: https://www.upwork.com/jobs/~0183904df145af1e22

@zanyrenney

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@fedirjh

🎯 ⚡️ Woah @fedirjh / @HezekielT, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @HezekielT got assigned: 2023-09-07 12:56:48 Z
when the PR got merged: 2023-09-11 02:34:50 UTC

On to the next one 🚀

Reviewing label has been removed, please complete the "BugZero Checklist".

@fedirjh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: android app - expand icon doesn't disappear immediately after sending the message #27015

If no regressions arise, payment will be issued on 2023-09-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment offer (Reviewer)
@HezekielT requires payment
@mejed-alkoutaini requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

BugZero Checklist:

Link to the PR: Performance: chat input #25758
Link to comment: Performance: chat input #25758 (comment)
Link to discussion: N/A This could have been caught during testing. Given that the refactor touched multiple files, it's common that some bugs are missed, in this case, a regression test could help catch these bugs.
Determine if we should create a regression test for this bug: ✅

Regression Test Proposal

Open any chat.
Start typing multiline messages until the expand icon appears.
Click on the send button.
Verify that the expand icon disappears immediately.

Do we agree 👍 or 👎

@fedirjh

Payment summary

@fedirjh requires payment offer (Reviewer) - this job is eligible for a 50% #urgency bonus - PAID $1500 due to urgency bonus.
@HezekielT requires payment - this job is eligible for a 50% #urgency bonus - PAID $1500 due to urgency bonus.
@mejed-alkoutaini requires payment offer (Reporter) - PAID $250 as before price change.

All payments complete, closing!

Navigation Menu

Repository navigation

[HOLD for payment 2023-09-18] [$1000] Android App - The resizing icon doesn't disappear immediately after sending the message #25975

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

23 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-09-18] [$1000] Android App - The resizing icon doesn't disappear immediately after sending the message #25975

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 25, 2023

melvin-bot commented on Aug 25, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Aug 29, 2023

zanyrenney commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

melvin-bot commented on Aug 29, 2023

23 remaining items

melvin-bot commented on Sep 11, 2023

melvin-bot commented on Sep 11, 2023

melvin-bot commented on Sep 11, 2023

melvin-bot commented on Sep 11, 2023

fedirjh commented on Sep 12, 2023

BugZero Checklist:

zanyrenney commented on Sep 18, 2023

zanyrenney commented on Sep 18, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions