[HOLD for payment 2023-10-16] [$500] Assign Task - Assignee field active in offline mode while assigning task, should be greyed out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Navigate to the "Assign task" section
3. Create a task by entering a title
4. Enable offline mode from Preferences
5. Select a user from the assignee field
6. Notice assignee field is not greyed out

Expected Result:

During offline mode, the assignee field should appear greyed out to indicate its inactivity while assigning a task

Actual Result:

The assignee field remains active and doesn't turn grey while assigning a task in offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.57-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-12-at-31853-am_RnxP47TY.1.mp4

Gravar.2977.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691792826667939

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb180f9f96ed4319
• Upwork Job ID: 1697586364732370944
• Last Price Increase: 2023-09-15

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee field active in offline mode while assigning task, should be greyed out

What is the root cause of that problem?

We don't set pendingField when editing assignee

App/src/libs/actions/Task.js

Line 511 in c435734

function editTaskAssigneeAndNavigate(report, ownerAccountID, assigneeEmail, assigneeAccountID = 0, assigneeChatReport = null) {

What changes do you think we should make in order to solve the problem?

In optimistic report data

App/src/libs/actions/Task.js

Lines 526 to 531 in c435734

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
	value: {
	reportName,
	managerID: assigneeAccountID || report.managerID,
	managerEmail: assigneeEmail || report.managerEmail,

we should add pending field managerID: update like this

pendingFields: {
        ...(assigneeAccountID && {managerID: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE}),
},

We also need to remove pendingFields when updating successful

What alternative solutions did you explore? (Optional)

[esh-g]

Proposal

Please re-state the problem we are trying to solve

The task assignee field is doesn't get greyed out when changed offline.

What is the root cause of this problem?

This was introduced in this PR: #22778
We are not setting the pendingField for managerID while editing task assignee in optimistic data

App/src/libs/actions/Task.js

Lines 525 to 534 in a03a21d

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
	value: {
	reportName,
	managerID: assigneeAccountID || report.managerID,
	managerEmail: assigneeEmail || report.managerEmail,
	},
	},
	];

Therefore, the pending field for managerID is always null and it never gets greyed out.

What changes do you think we should make in order to solve the problem?

1. We should add the pendingField to the optimistic data while editing task assignee like this:

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
    value: {
        reportName,
        managerID: assigneeAccountID || report.managerID,
        managerEmail: assigneeEmail || report.managerEmail,
        pendingFields: {managerID: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE}, // add this line
    },
},

2. In success data, we should add the following to clear out the pending fields

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
    value: {pendingFields: {managerID: null}}
}

This is the same approach we follow editTaskAndNavigate function.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

@allroundexperts - do you think this bug report & problem is a dupe of #23200? Would love your input!

[michaelhaxhiu]

Yep this feels and looks like a dupe, and the other GH is addressing it. Closing.

[ayazhussain79]

@michaelhaxhiu This bug #23200 PR merged but #25956 is still reproducible @allroundexperts can you please also check this one

[michaelhaxhiu]

Hmm let's see what's suggested on #23200 from those involved. You may be due a bug reporting bounty if this is indeed "separate" and thus unique.