[HOLD for payment 2023-09-21] [$500] Request Money/Scan: Validation messages are not translated to Spanish

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click plus button, choose Request Money.
2. Click scan tab, drag an invalid file to the scan tab (too big > 25MB or too small < 240KB), a validation modal will show.
3. Open a new tab, change the current language to Spanish.
4. Notice that validation messages are not translated to Spanish.

Expected Result:

Validation messages should be translated to Spanish

Actual Result:

Validation messages are not translated to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-13.At.11.24.39.mp4

Recording.1315.mp4

Expensify/Expensify Issue URL:

Issue reported by: @hungvu193

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691900667713019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fbfb6ee98fe603c3
• Upwork Job ID: 1696537225664692224
• Last Price Increase: 2023-09-01
• Automatic offers:
• aimane-chnaif | Reviewer | 26568326
• hungvu193 | Contributor | 26568328
• hungvu193 | Reporter | 26568330

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[izarutskaya]

Proposal from @hungvu193

Please re-state the problem that we are trying to solve in this issue.

Request Money/Scan: Validation messages are not translated to Spanish

What is the root cause of that problem?

We're setting the validation message here, instead of translateKey, because of that when the language is changed, it didn't change to Spanish:

App/src/libs/ReceiptUtils.js

Lines 8 to 26 in a03a21d

	const validateReceipt = (file) => {
	const {fileExtension} = FileUtils.splitExtensionFromFileName(lodashGet(file, 'name', ''));
	if (_.contains(CONST.API_ATTACHMENT_VALIDATIONS.UNALLOWED_EXTENSIONS, fileExtension.toLowerCase())) {
	Receipt.setUploadReceiptError(true, Localize.translateLocal('attachmentPicker.wrongFileType'), Localize.translateLocal('attachmentPicker.notAllowedExtension'));
	return false;
	}
	if (lodashGet(file, 'size', 0) > CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE) {
	Receipt.setUploadReceiptError(true, Localize.translateLocal('attachmentPicker.attachmentTooLarge'), Localize.translateLocal('attachmentPicker.sizeExceeded'));
	return false;
	}
	if (lodashGet(file, 'size', 0) < CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE) {
	Receipt.setUploadReceiptError(true, Localize.translateLocal('attachmentPicker.attachmentTooSmall'), Localize.translateLocal('attachmentPicker.sizeNotMet'));
	return false;
	}
	return true;
	};

What changes do you think we should make in order to solve the problem?

We should use translateKey only, so we need to remove all the Localize.translateLocal from our validateReceipt function. For example:

Receipt.setUploadReceiptError(true,'attachmentPicker.attachmentTooLarge', 'attachmentPicker.sizeExceeded');

After that, we should also update our ConfirmModal here, to make it translate the translateKey:

            <ConfirmModal
                title={attachmentInvalidReasonTitle ? translate(attachmentInvalidReasonTitle) :''}
                onConfirm={Receipt.clearUploadReceiptError}
                onCancel={Receipt.clearUploadReceiptError}
                isVisible={isAttachmentInvalid}
                prompt={attachmentInvalidReason ? translate(attachmentInvalidReason) : ''}
                confirmText={translate('common.close')}
                shouldShowCancelButton={false}
            />

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Similar to #25704 (comment), seeing as this is low-priority and not necessarily an upgrade to the app's functionality, I am reducing the payscale for this issue to the following:

• Bug reporting bonus: $250
• Contributor fix: $500
• C+ proposal/PR review: $500

Just noting this before I add the labels to accept proposals.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fbfb6ee98fe603c3