Skip to content

[Awaiting C+ payment] [HOLD for payment 2023-09-06] [Performance] Composer typing is slow #25763

Closed
Closed
[Awaiting C+ payment] [HOLD for payment 2023-09-06] [Performance] Composer typing is slow#25763
Assignees
trjExpensifyhannojgrushatgabhanemountiny
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Description

@mountiny
mountiny
opened on Aug 23, 2023

Problem

When typing in a composer, especially on desktop or web, the input has a delay and feels sluggish.

### Solution

Identify what is causing this unnecessary delay and fix it

Activity

  1. mountiny
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 23, 2023
  2. mountiny
    self-assigned this
    on Aug 23, 2023
  3. mountiny
    added this to [#whatsnext] #qualityon Aug 23, 2023
  4. melvin-bot
    assigned
    trjExpensify
    on Aug 23, 2023

  5. melvin-bot commented on Aug 23, 2023

    @melvin-bot
    melvin-botbot
    on Aug 23, 2023

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Aug 23, 2023

    @melvin-bot
    melvin-botbot
    on Aug 23, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  7. mountiny commented on Aug 23, 2023

    @mountiny
    mountiny
    on Aug 23, 2023
    ContributorAuthor

    @hannojg Can you comment on this issue please?

  8. mountiny
    moved this to In Progress in [#whatsnext] #qualityon Aug 23, 2023

  9. trjExpensify commented on Aug 23, 2023

    @trjExpensify
    trjExpensify
    on Aug 23, 2023
    Contributor

    Haha, best solution summary eveeer Vit! 😏

  10. mountiny commented on Aug 23, 2023

    @mountiny
    mountiny
    on Aug 23, 2023
    ContributorAuthor

    @trjExpensify Thanks, Tom. It just takes years of practice and self-discipline

  11. hannojg commented on Aug 23, 2023

    @hannojg
    hannojg
    on Aug 23, 2023
    Contributor

    👋 @mountiny

  12. mountiny
    assigned
    hannojg
    on Aug 24, 2023
  13. melvin-bot
    added
    ReviewingHas a PR in review
    and removed
    DailyKSv2
    on Aug 27, 2023

  14. 14 remaining items

  15. mountiny
    assigned
    rushatgabhane
    on Sep 7, 2023

  16. trjExpensify commented on Sep 7, 2023

    @trjExpensify
    trjExpensify
    on Sep 7, 2023
    Contributor

    Cool, so @rushatgabhane can you submit a request for reimbursement?

    @mountiny @hannojg are you guys taking the checklist, or handled limiting these performance regressions else where?

  17. mountiny commented on Sep 7, 2023

    @mountiny
    mountiny
    on Sep 7, 2023
    ContributorAuthor

    Yep this will be part of the project for performance to monitor rerenders and such, thanks

  18. mountiny
    moved this from In Progress to LOW in [#whatsnext] #qualityon Sep 7, 2023
  19. mountiny
    moved this from LOW to HIGH in [#whatsnext] #qualityon Sep 7, 2023
  20. mountiny
    moved this from HIGH to Done in [#whatsnext] #qualityon Sep 7, 2023

  21. trjExpensify commented on Sep 8, 2023

    @trjExpensify
    trjExpensify
    on Sep 8, 2023
    Contributor

    Excellent so just need to confirm $1,000 to @rushatgabhane for the C+ review. Thanks!

  22. melvin-bot
    added
    Overdue
    on Sep 11, 2023

  23. trjExpensify commented on Sep 11, 2023

    @trjExpensify
    trjExpensify
    on Sep 11, 2023
    Contributor

    No change, Melv. Waiting for @rushatgabhane to get his request in and paid.

  24. melvin-bot
    removed
    Overdue
    on Sep 11, 2023
  25. trjExpensify
    changed the title [-][HOLD for payment 2023-09-06] [Performance] Composer typing is slow[/-] [+][Awaiting C+ payment] [HOLD for payment 2023-09-06] [Performance] Composer typing is slow[/+] on Sep 11, 2023

  26. rushatgabhane commented on Sep 11, 2023

    @rushatgabhane
    rushatgabhane
    on Sep 11, 2023
    Member

    thanks! created a manual request here - https://staging.new.expensify.com/r/8831737758297952

    this issue can be closed as the payment will be tracked on new dot

  27. trjExpensify commented on Sep 11, 2023

    @trjExpensify
    trjExpensify
    on Sep 11, 2023
    Contributor

    Cool!

  28. trjExpensify
    closed this as completedon Sep 11, 2023

  29. JmillsExpensify commented on Oct 7, 2023

    @JmillsExpensify
    JmillsExpensify
    on Oct 7, 2023
    Contributor

    $1,000 payment approved for @rushatgabhane based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions