You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [Awaiting payment]The formatting of the time is zero-prefixed #25650
The formatting of the time should not be zero-prefixed
Actual Result:
The formatting of the time is zero-prefixed
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.56-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@allroundexperts@MonilBhavsar@waterim@laurenreidexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
Activity
melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Aug 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 22, 2023
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.hungvu193 commentedon Aug 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The formatting of the time is zero-prefixed
What is the root cause of that problem?
We updated the format for local time here which caused this issue:
App/src/CONST.js
Line 131 in 120bcbf
What changes do you think we should make in order to solve the problem?
We should update this:
App/src/CONST.js
Line 131 in 120bcbf
to:
What alternative solutions did you explore? (Optional)
N/A
36 remaining items
melvin-bot commentedon Sep 7, 2023
Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 7, 2023
Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.
laurenreidexpensify commentedon Sep 7, 2023
Woops forgot @allroundexperts was on the C+ payment pilot
laurenreidexpensify commentedon Sep 7, 2023
@MonilBhavsar just to be clear - is there no C payment here, it's only $1000 for @allroundexperts is that corretc?
MonilBhavsar commentedon Sep 7, 2023
Correct, contributor -
@waterimare from expert agency. Also just to note, this was a regression from #24446melvin-bot commentedon Sep 11, 2023
@allroundexperts, @MonilBhavsar, @waterim, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Sep 11, 2023
@allroundexperts, @MonilBhavsar, @waterim, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
MonilBhavsar commentedon Sep 11, 2023
@laurenreidexpensify is partially ooo today
melvin-bot commentedon Sep 12, 2023
@allroundexperts @MonilBhavsar @waterim @laurenreidexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
laurenreidexpensify commentedon Sep 12, 2023
Payment summary:
When @allroundexperts confirms payment has been requested we can close
allroundexperts commentedon Sep 12, 2023
Hi @laurenreidexpensify!
This was a regression. As such, there isn't any payment due here.