Skip to content

Dev: Delay in removing 'New' marker After deleting newly sent message #25606

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat 

  2. Send a message
  3. 
Click on “Mark as unread”
  4. Now delete the message

  5. Notice new marker not removed with message

Expected Result:

New marker should be removed when deleting new sent message

Actual Result:

New marker not removed when deleting new sent message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: Dev
Reproducible in production?: Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-18-at-20915-am_ByAuGnth.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692306828126859

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 21, 2023
  2. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. hayata-suenaga commented on Aug 21, 2023

    @hayata-suenaga
    Contributor

    on it now. Testing if this bug is already on production (i.e. checking if this is actually a deploy blocker).

  7. hayata-suenaga commented on Aug 21, 2023

    @hayata-suenaga
    Contributor

    okay I cannot re-produce this on production. If this issue is present on staging, then this is a deploy blocker.

    Screen.Recording.2023-08-21.at.11.22.41.AM.mov
  8. 19 remaining items

  9. stephanieelliott commented on Aug 31, 2023

    @stephanieelliott
    Contributor

    Work ongoing in #23171

  10. stephanieelliott commented on Sep 21, 2023

    @stephanieelliott
    Contributor

    Still working in #23171

  11. stephanieelliott commented on Sep 29, 2023

    @stephanieelliott
    Contributor

    #23171 still open

  12. stephanieelliott commented on Oct 4, 2023

    @stephanieelliott
    Contributor

    Still working in #23171

  13. stephanieelliott commented on Oct 11, 2023

    @stephanieelliott
    Contributor

    #23171 still ongoing

  14. stephanieelliott commented on Oct 17, 2023

    @stephanieelliott
    Contributor

    Still working in #23171

  15. stephanieelliott commented on Oct 30, 2023

    @stephanieelliott
    Contributor

    #23171 still ongoing

  16. stephanieelliott commented on Nov 6, 2023

    @stephanieelliott
    Contributor

    Still working in #23171

  17. stephanieelliott commented on Nov 13, 2023

    @stephanieelliott
    Contributor

    Still working in #23171

  18. gedu commented on Nov 27, 2023

    @gedu
    Contributor

    I will review it too

  19. gedu commented on Nov 27, 2023

    @gedu
    Contributor

    Can not reproduce it.
    I'm seeing just an small delay but correspond with the re-render and the list sorting.

    Screen.Recording.2023-11-27.at.10.52.10.mp4
  20. hayata-suenaga commented on Nov 27, 2023

    @hayata-suenaga
    Contributor

    compared with the video in the original issue, the problem seems to have been fixed. We can close this. Do we need any payment @stephanieelliott ?

  21. stephanieelliott commented on Nov 28, 2023

    @stephanieelliott
    Contributor

    Great! No payment due here as work was done by a Callstack expert contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringNeeds ReproductionReproducible steps neededReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions