Repository navigation
[HOLD for payment 2023-09-27] [$1000] Add PrivateNotes pages to allow users to add private notes on report #25489
Description
High-level of proposed solution
Add a private notes section to the ‘details’ pane of each room and DM to allow all new dot users to collect notes about other users/rooms while messaging customers. Each room and DM will have one, continuous private note. This will save the step of switching apps when taking/referring to notes and encourage users to use NewDot when messaging by making it our source of truth for contact information.
Add a section in details for private notes
We’ll add a section in the details pane with the title ‘Private Notes’. In the Personal Details of a DM, it will fit below the ‘Message ’ section. In the Room Details, it will fit between the ‘Invite’ and ‘Leave Room’ sections. We’ll keep the character limit of 15k we’re currently using for messages to standardize.
Create a single note for each DM and room for each member
Each room and DM will have a single, continuous note for each member. To maintain consistency with other forms and textboxes, we’ll include a ‘Save’ button and allow users to write in markdown.
Ex. In a DM between Ava and Betty, there will be two notes. In a room where Ava, Betty, and Callum are all members, there will be three notes. None of the members will be able to access another member’s note (except in the special situation immediately below).
Allow Team Expensify user and Expensify employees to view notes added by other Team Expensify users
Context in Guides’ private notes will be helpful when a customer gets a new “owner” (e.g. AM steps in after a won deal, Guide steps in after another Guide leaves). Additionally, these notes will be helpful to a Guide’s mentor when catching up on what’s happening in preparation for a call and keeping track of a deal in general.
To give the new owner and/or mentor visibility into the notes for a deal/customer, we’ll allow users with @expensify.com (Mentors) and @team.expensify.com (Guides and AMs) logins to view notes written by @team.expensify.com logins in rooms and DMs they are members of.
Notes for Completeness:
- Each @team.expensify.com login that is a member of a room or DM will show as an entry in the Private Notes section if they’ve added notes.
- Tapping on an entry will show the notes in read-only mode. There will be no option to write/edit other users’ notes.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~018981f5d13dbcc635
- Upwork Job ID: 1693596798257332224
- Last Price Increase: 2023-08-21
Activity
techievivek commentedon Aug 21, 2023
Although this is a new feature, we need the help of a C+ member to review it. I am adding the bug label so a bug-zero member can assist with the payment. Thanks
melvin-bot commentedon Aug 21, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 21, 2023
[-]Add PrivateNotes pages to allow users to add private notes on report[/-][+][$1000] Add PrivateNotes pages to allow users to add private notes on report[/+]melvin-bot commentedon Aug 21, 2023
Job added to Upwork: https://www.upwork.com/jobs/~018981f5d13dbcc635
melvin-bot commentedon Aug 21, 2023
Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.
46 remaining items
techievivek commentedon Sep 25, 2023
Hmm, they don't have access to any expensify email address or team expensify email address so I think we can just put it in the regression test proposal but they will never be able to test that.
techievivek commentedon Sep 25, 2023
Ok, just created the issue for adding the new regression tests.
strepanier03 commentedon Sep 27, 2023
Back in office just in time for this to be paid, working on it now.
strepanier03 commentedon Sep 27, 2023
Thank you @techievivek for helping out with the regression test step 🙌
strepanier03 commentedon Sep 27, 2023
Payment summary
@sobitneupane - Please put in your manual request for payment and I'll assign Jason once you confirm that's done.
techievivek commentedon Oct 2, 2023
@sobitneupane Did you have a look at the above comment and put a manual request?
sobitneupane commentedon Oct 4, 2023
Sorry for the delay. I will make the request by the weekend. In the meantime, I think we are good to close this issue.
techievivek commentedon Oct 4, 2023
Ok, great, thanks.
sobitneupane commentedon Oct 9, 2023
#25489 (comment)
Requested payment on newDot
JmillsExpensify commentedon Oct 9, 2023
$1,000 payment approved for @sobitneupane based on BZ summary.