[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money

@niravkakadiya25

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

click "+" button
select request money
try to slide right to left

Expected Result:

selection change should be immediately

Actual Result:

selection change takes some time

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-16.at.5.42.59.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691384151135339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010c514d8b4722d88a
Upwork Job ID: 1692452963606020096
Last Price Increase: 2023-08-18

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tab change not animating when screen is swiped when on MoneyRequestPage.

What is the root cause of that problem?

The root cause is that we're having static values as background colours for the buttons, icons and text inside the tab.

What changes do you think we should make in order to solve the problem?

We need to make use of the position property here and pass that onto the TabSelector component. Inside it, we need to interpolate this position value between:

Background colour of the button in selected / un-selected state.
Text colour of the button in selected / un-selected state.
Icon colour of the button in selected / un-selected state.

These interpolated values of colours are then to be used inside TabSelectorItem component. This will result in a smooth transition which will dispel the lag effect.

What alternative solutions did you explore? (Optional)

We can also just disable the swipe on web so that the user can only switch the tab by pressing the button itself. However, I think that the solution proposed above is more elegant.

Job added to Upwork: https://www.upwork.com/jobs/~010c514d8b4722d88a

@greg-schroeder

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

@burczu

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

@allroundexperts

I can't repro DEV issues - I'm assuming since you made a proposal here @allroundexperts that you were able to?

@niravkakadiya25

Offer sent to @niravkakadiya25. @allroundexperts you can make a manual request. All that's left is the checklist.

Requested.

$1,000 payment approved via NewDot based on BZ summary.

@burczu

Bump on the checklist @burczu and then we can close this out!

@burczu

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR: this is not regression
[@burczu / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: -
[@burczu / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: -
[@burczu / @allroundexperts] Determine if we should create a regression test for this bug.
[@burczu / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@burczu

@burczu @greg-schroeder @allroundexperts @thienlnam this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@burczu

Current assignees @burczu and @allroundexperts are eligible for the Internal assigner, not assigning anyone new.

Navigation Menu

Repository navigation

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

67 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 17, 2023

melvin-bot commented on Aug 17, 2023

Bug0 Triage Checklist (Main S/O)

allroundexperts commented on Aug 17, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 18, 2023

melvin-bot commented on Aug 18, 2023

melvin-bot commented on Aug 18, 2023

greg-schroeder commented on Aug 18, 2023

67 remaining items

greg-schroeder commented on Sep 8, 2023

allroundexperts commented on Sep 9, 2023

JmillsExpensify commented on Sep 10, 2023

greg-schroeder commented on Sep 12, 2023

burczu commented on Sep 13, 2023

melvin-bot commented on Sep 14, 2023

melvin-bot commented on Sep 14, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions