Skip to content

[HOLD for payment 2024-03-13] [TS migration] Migrate 'react-native.js' mock to TypeScript #25256

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
mocks/react-native.js 3
mocks/pusher-js/react-native.js 1

Activity

  1. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    Author

    @melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  3. moved this from Done to Todo in Typescript migrationon Nov 29, 2023
  4. 24 remaining items

  5. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    Author

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

  7. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    Author

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@JKobrynski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  8. alitoshmatov commented on Mar 13, 2024

    @alitoshmatov
    Contributor

    Can someone assign me to this issue to handle payment for review of the PR

  9. situchan commented on Mar 13, 2024

    @situchan
    Contributor

    Payment is not needed for these kinds of PRs as per https://expensify.slack.com/archives/C02NK2DQWUX/p1707999906110839

  10. melvin-bot commented on Mar 13, 2024

    @melvin-bot
    Author

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions