Skip to content

[HOLD for payment 2023-09-18] [TS migration] Migrate 'ControlSelection' lib to TypeScript #24802

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/ControlSelection/index.native.js 0
src/libs/ControlSelection/index.js 1

Activity

  1. kowczarz commented on Sep 5, 2023

    @kowczarz
    Contributor

    Hey! I’m Kamil Owczarz from Software Mansion, an expert agency, and I’d like to work on this issue!

  2. melvin-bot commented on Sep 6, 2023

    @melvin-bot
    Author

    Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  3. roryabraham commented on Sep 11, 2023

    @roryabraham
    Contributor

    PR merged w/o C+ review. Going to close this

  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 11, 2023
  5. changed the title [-][TS migration] Migrate 'ControlSelection' lib to TypeScript[/-] [+][HOLD for payment 2023-09-18] [TS migration] Migrate 'ControlSelection' lib to TypeScript[/+] on Sep 11, 2023
  6. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-18. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions