[HOLD for payment 2023-08-28] [$1000] IOU - Workspace avatar shows 'U' avatar before reverting to actual avatar in IOU view

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #23043

Action Performed:

1. Go to staging.new.expensify.com
2. Request money in a workspace chat
3. Click on the IOU preview
4. Click on the IOU again

Expected Result:

The workspace avatar shows the correct avatar

Actual Result:

The workspace avatar shows 'U' avatar before reverting to the actual avatar.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159056_20230809_224632.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01698449a42b0e216c
• Upwork Job ID: 1689577432456220672
• Last Price Increase: 2023-08-10
• Automatic offers:
• situchan | Reviewer | 26110136
• StevenKKC | Contributor | 26110138

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace avatar shows 'U' avatar before reverting to actual avatar in IOU view.

What is the root cause of that problem?

If we click IOU preview in the money request page, onIOUPreviewPressed is executed.
Since there is no child thread data in Onyx, app generates optimistic child thread data, and set the child thread's policyID to CONST.POLICY.OWNER_EMAIL_FAKE.
And then send OpenReport API to BE, and navigate to the child thread.

App/src/components/ReportActionItem/MoneyRequestAction.js

Lines 101 to 121 in 202f2eb

	const thread = ReportUtils.buildOptimisticChatReport(
	participantAccountIDs,
	props.translate(ReportActionsUtils.isSentMoneyReportAction(props.action) ? 'iou.threadSentMoneyReportName' : 'iou.threadRequestReportName', {
	formattedAmount: ReportActionsUtils.getFormattedAmount(props.action),
	comment: props.action.originalMessage.comment,
	}),
	'',
	CONST.POLICY.OWNER_EMAIL_FAKE,
	CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	false,
	'',
	undefined,
	undefined,
	CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
	props.action.reportActionID,
	props.requestReportID,
	);
	const userLogins = PersonalDetailsUtils.getLoginsByAccountIDs(thread.participantAccountIDs);
	Report.openReport(thread.reportID, userLogins, thread, props.action.reportActionID);
	Navigation.navigate(ROUTES.getReportRoute(thread.reportID));

Because the report's policyID is CONST.POLICY.OWNER_EMAIL_FAKE, ReportUtils.getPolicyName returns Unavailable Workspace, and then ReportUtils.getWorkspaceAvatar returns WorkspaceUavatar.
So 'U' is shown in money request header.

App/src/libs/ReportUtils.js

Lines 568 to 583 in 202f2eb

	function getPolicyName(report, returnEmptyIfNotFound = false, policy = undefined) {
	const noPolicyFound = returnEmptyIfNotFound ? '' : Localize.translateLocal('workspace.common.unavailable');
	if (_.isEmpty(report)) {
	return noPolicyFound;
	}
	if ((!allPolicies || _.size(allPolicies) === 0) && !report.policyName) {
	return Localize.translateLocal('workspace.common.unavailable');
	}
	const finalPolicy = policy || _.get(allPolicies, `${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`);
	// Public rooms send back the policy name with the reportSummary,
	// since they can also be accessed by people who aren't in the workspace
	return lodashGet(finalPolicy, 'name') || report.policyName || report.oldPolicyName || noPolicyFound;
	}

App/src/libs/ReportUtils.js

Lines 859 to 862 in 202f2eb

	function getWorkspaceAvatar(report) {
	const workspaceName = getPolicyName(report, allPolicies);
	return lodashGet(allPolicies, [`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`, 'avatar']) || getDefaultWorkspaceAvatar(workspaceName);
	}

App/src/libs/ReportUtils.js

Lines 845 to 857 in 202f2eb

	function getDefaultWorkspaceAvatar(workspaceName) {
	if (!workspaceName) {
	return defaultWorkspaceAvatars.WorkspaceBuilding;
	}
	// Remove all chars not A-Z or 0-9 including underscore
	const alphaNumeric = workspaceName
	.normalize('NFD')
	.replace(/[^0-9a-z]/gi, '')
	.toUpperCase();
	return !alphaNumeric ? defaultWorkspaceAvatars.WorkspaceBuilding : defaultWorkspaceAvatars[`Workspace${alphaNumeric[0]}`];
	}

After OpenReport API returns the thread report data, app showes the correct workspace avatar, since the thread has a corrrect policyID.

Therefore, workspace avatar shows 'U' avatar before reverting to actual avatar in IOU view.

What changes do you think we should make in order to solve the problem?

We can set the optimistic child thread's policyID to correct value.
Because the props.iouReport has a correct policyID, we can set the optimistic thread's policyID to props.iouReport policyID instead of CONST.POLICY.OWNER_EMAIL_FAKE.

    lodashGet(props.iouReport, 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE),

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01698449a42b0e216c

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[kaomoua]

Hi. I can not see the proposal of @situchan. But how was he assigned to this issue?
I am new here and I really don't know how to contribute to Expensify.

[kaomoua]

Hi. I can not see the proposal of @situchan. But how was he assigned to this issue?
I am new here and I really don't know how to contribute to Expensify.