[HOLD for payment 2023-11-01] [$1000] Tooltips should not show when the related context menu is open

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

This is follow up from #15289

Action Performed:

Break down in numbered steps
Example 1:

Open an existing chat
Send a message
Hover over the message & react with one of the emojis
Right-click on the newly added emoji & verify that a popover modal is displayed
As the popover modal is opened, hover the emoji you reacted with

AND

Example 2:

Click + button on LHN.
Hover over the X icon
Click + in composer
Hover over + icon

Expected Result:

Describe what you think should've happened
Example 1:
Tooltip & popover modal are not overlapped

Example 2:
Should not see tooltip in either hover state

Actual Result:

Describe what actually happened
Example 1:
Tooltip & popover modal are overlapped

Example 2:
See tooltip in both hover states

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.51-2
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019da84618f039e6f7
Upwork Job ID: 1689711722778017792
Last Price Increase: 2023-08-31

@laurenreidexpensify

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I reported first

@NicMendonca

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reassigning as this got assigned at 9pm the evening before I am OOO for 5 days

Reviewing label has been removed, please complete the "BugZero Checklist".

@allroundexperts

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Add popover anchor tooltip #30150

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@allroundexperts does not require payment (Eligible for Manual Requests)
@situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts / @situchan] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts / @situchan] Determine if we should create a regression test for this bug.
[@allroundexperts / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Bump on BZ summary ☝️

@allroundexperts

Reporter: N.A
Contributor: @allroundexperts - paid via Expensify - $1,500
C+: @situchan - paid via Upwork - $1,500

The PR that introduced the bug has been identified. Link to the PR: This is follow-up of popover refactor for non-overlay
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This is kind of polish than bug and doesn't affect user experience. So I propose no regression test.

@situchan

@situchan the upwork job expired, so just making a new one!

@allroundexperts pls request payment via Expensify

@situchan

@situchan sent you the offer

@situchan

@situchan you've been paid!

Payment summary

Thanks everyone!

@allroundexperts

$1,500 payment approved for @allroundexperts based on this comment.

Navigation Menu

Repository navigation

[HOLD for payment 2023-11-01] [$1000] Tooltips should not show when the related context menu is open #24296

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Bug0 Triage Checklist (Main S/O)

120 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-11-01] [$1000] Tooltips should not show when the related context menu is open #24296

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 8, 2023

melvin-bot commented on Aug 8, 2023

Bug0 Triage Checklist (Main S/O)

tewodrosGirmaA commented on Aug 9, 2023

melvin-bot commented on Aug 9, 2023

melvin-bot commented on Aug 9, 2023

Bug0 Triage Checklist (Main S/O)

laurenreidexpensify commented on Aug 9, 2023

120 remaining items

melvin-bot commented on Oct 25, 2023

melvin-bot commented on Oct 25, 2023

melvin-bot commented on Oct 25, 2023

NicMendonca commented on Nov 2, 2023

NicMendonca commented on Nov 2, 2023

situchan commented on Nov 2, 2023

NicMendonca commented on Nov 2, 2023

NicMendonca commented on Nov 2, 2023

NicMendonca commented on Nov 2, 2023

JmillsExpensify commented on Nov 3, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions