[$1000] Web-Workspace-App does nothing on clicking on 3 dots when modal is open (modal closes for phone)

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspace
3. Click on 3 dots, modal will be displayed, again click on 3 dots and observe that it does nothing
4. Visit any user report, click on phone icon in header, it will open modal, again click on phone icon and observe that it will close the modal
5. Similar working happens for all other modals like Actions, New, Emoji

Expected Result:

App should close the modal when we click on 3 dots again like it does for all other type of modals throughout the app

Actual Result:

App does nothing when we click on 3 dots again

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.1134.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691491820472469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ad6bb952da737f6
• Upwork Job ID: 1691525643834966016
• Last Price Increase: 2023-08-15
• Automatic offers:
• aimane-chnaif | Reviewer | 26139650
• ishpaul777 | Contributor | 26139655

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web-Workspace-App does nothing on clicking on 3 dots when modal is open

What is the root cause of that problem?

we are not closing the popover here only opening the popover using this.showPopoverMenu() on press of button

These are all non-toggle popovers and closing of the popovers not handeled :

1. ThreeDotsMenu
2. AddPaymentMethodMenu
3. ButtonWithDropdownMenu

What changes do you think we should make in order to solve the problem?

1. changes for ThreeDotsMenu
   add the condition to close popover if isPopupMenuVisible is true (popover is open) using this.hidePopoverMenu()

                        onPress={() => {
                                if (this.state.isPopupMenuVisible) {
                                    this.hidePopoverMenu();
                                    return;
                                }
                                this.showPopoverMenu();
                                if (this.props.onIconPress) { 
                                    this.props.onIconPress();
                                }
                            }}

note: i am not sure if we should call onIconPress both on opening and closing. currently ThreeDotMenu is used in HeaderView (onIconPress is not defined using default prop - () => {})and function HeaderWithBackButton defined but still it is a default prop () => {}

2. changes for AddPaymentMethodMenu in payments page
   add the following condition here

 const paymentMethodPressed = (nativeEvent, accountType, account, isDefault, methodID) => {
        if(shouldShowAddPaymentMenu) {
            setShouldShowAddPaymentMenu(false);
            return;
        }
// rest of code

In BaseKYCWall add following changes: (wasn't able to test this properly i dont have beta access)

 continue(event, iouPaymentType) {
          if (this.state.shouldShowAddPaymentMenu) {
                this.setState({shouldShowAddPaymentMenu: false});
                return;
            }
      //.....

3. changes for ButtonWithDropdownMenu.

onPress={() => setIsMenuVisible(!isMenuVisible)}
// or onPress={() => setIsMenuVisible((prev) => !prev)}