[HOLD for payment 2023-08-17] [$1000] [HOLD for payment 2023-08-16] The total requested amount does not update until the IOU is clicked on or the page is refreshed

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the plus sign and select "request money."
2. Enter the desired amount and recipient's email address, and click "request money."
3. Repeat step 2 to make a second request with the same recipient.
4. Delete the first request from the reply thread.
5. Observe that the total requested amount does not update in real-time.

Expected Result:

The total requested amount should update in real-time after deleting the first request and making a second one.

Actual Result:

The total requested amount does not update until the IOU is clicked on or the page is refreshed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-08T044732.549.webm

screen-capture.-.2023-08-08T043901.984.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691494603760399
reported earlier in
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691444951222519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136af4481ecaa59a7
• Upwork Job ID: 1689346748730482688
• Last Price Increase: 2023-08-09
• Automatic offers:
• StevenKKC | Contributor | 26035056

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The total requested amount does not update until the IOU is clicked on or the page is refreshed

What is the root cause of that problem?

When we delete a request money, report.total is changed

But in ReportActionItem we don't check the report.total to re-render MoneyReportView here

App/src/pages/home/report/ReportActionItem.js

Lines 601 to 620 in dd21a0b

	memo(
	ReportActionItem,
	(prevProps, nextProps) =>
	prevProps.displayAsGroup === nextProps.displayAsGroup &&
	prevProps.draftMessage === nextProps.draftMessage &&
	prevProps.isMostRecentIOUReportAction === nextProps.isMostRecentIOUReportAction &&
	prevProps.hasOutstandingIOU === nextProps.hasOutstandingIOU &&
	prevProps.shouldDisplayNewMarker === nextProps.shouldDisplayNewMarker &&
	_.isEqual(prevProps.emojiReactions, nextProps.emojiReactions) &&
	_.isEqual(prevProps.action, nextProps.action) &&
	_.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) &&
	_.isEqual(prevProps.report.errorFields, nextProps.report.errorFields) &&
	lodashGet(prevProps.report, 'statusNum') === lodashGet(nextProps.report, 'statusNum') &&
	lodashGet(prevProps.report, 'stateNum') === lodashGet(nextProps.report, 'stateNum') &&
	prevProps.translate === nextProps.translate &&
	// TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport
	ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) &&
	prevProps.action.actionName === nextProps.action.actionName &&
	prevProps.report.reportName === nextProps.report.reportName &&
	prevProps.report.description === nextProps.report.description &&

What changes do you think we should make in order to solve the problem?

We should add the check here to re-render MoneyReportView when the report.total is changed

memo(
        ReportActionItem,
        (prevProps, nextProps) =>
        ...
        // Check to re-render MoneyReportView
        lodashGet(prevProps.report, 'total', 0) === lodashGet(nextProps.report, 'total', 0)

App/src/pages/home/report/ReportActionItem.js

Lines 601 to 620 in dd21a0b

	memo(
	ReportActionItem,
	(prevProps, nextProps) =>
	prevProps.displayAsGroup === nextProps.displayAsGroup &&
	prevProps.draftMessage === nextProps.draftMessage &&
	prevProps.isMostRecentIOUReportAction === nextProps.isMostRecentIOUReportAction &&
	prevProps.hasOutstandingIOU === nextProps.hasOutstandingIOU &&
	prevProps.shouldDisplayNewMarker === nextProps.shouldDisplayNewMarker &&
	_.isEqual(prevProps.emojiReactions, nextProps.emojiReactions) &&
	_.isEqual(prevProps.action, nextProps.action) &&
	_.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) &&
	_.isEqual(prevProps.report.errorFields, nextProps.report.errorFields) &&
	lodashGet(prevProps.report, 'statusNum') === lodashGet(nextProps.report, 'statusNum') &&
	lodashGet(prevProps.report, 'stateNum') === lodashGet(nextProps.report, 'stateNum') &&
	prevProps.translate === nextProps.translate &&
	// TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport
	ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) &&
	prevProps.action.actionName === nextProps.action.actionName &&
	prevProps.report.reportName === nextProps.report.reportName &&
	prevProps.report.description === nextProps.report.description &&

What alternative solutions did you explore? (Optional)