[Awaiting payment] [$1000] After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message

@ayazhussain79

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Log in to userA's account.
Go to Settings > Workspace > New Workspace.
Go to Member > Invite > Select user B.
Go to the 'announce' chat of the created workspace.
Pin the 'announce' chat to view the LHN properly.
Open another browser and login with userB’s account.
Go to the 'announce' page of userA's workspace.
Send an image to the announce chat.
Go back to userA’s account.
Send a message and delete it.
Now go to the userB’s account and delete the attachment.
Notice userA’s LHN displays '[Attachment]' instead of 'No activity yet'.

Expected Result:

After deleting an attachment, 'No activity yet' should be displayed in the LHN for userA

Actual Result:

After deleting a file, '[Attachment]' is shown in the LHN instead of 'No activity yet' until you delete one more message

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-01-at-15626-am_xKx12L9W.1.mp4

Recording.5769.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690838025775809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0188933d8c36eb686a
Upwork Job ID: 1688791645877243904
Last Price Increase: 2023-08-22
Automatic offers:

pradeepmdk | Contributor | 26490195

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Repro:

Job added to Upwork: https://www.upwork.com/jobs/~0188933d8c36eb686a

@kadiealexander

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

It seems this issue relate to lastMessageTranslationKey that we haven't done from BE side

@msapple0338

📣 @msapple0338! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

The PR that introduced the bug has been identified. Link to the PR: the logic was added in Fix: Translation for system message #21780, but I wouldn't say the bug was introduced by this PR, this was mainly a BE issue we resolved on FE. Still leaving a comment on the PR to myself and others to test more complex test cases
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21780/files#r1337040240
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Don't think an additional discussion is needed, this isn't a new type of bug, just something we should test more thoroughly for

Regression Test Proposal

Log in to userA's account.
Go to Settings > Workspace > New Workspace.
Go to Member > Invite > Select user B.
Go to the 'announce' chat of the created workspace.
Open another browser and login with userB’s account.
Go to the 'announce' page of userA's workspace.
Send an image to the announce chat.
Go back to userA’s account.
Send a message and delete it.
Now go to the userB’s account and delete the attachment.
Verify userA’s LHN displays 'No activity yet'.

Do we agree 👍 or 👎

@kadiealexander

The automation for this failed for some reason, instead creating a payment issue: #27374, so posting a BugZero Checklist manually here

cc: @kadiealexander

@kadiealexander

i think bot is not triggered for payment.
cc: @kadiealexander

@ayazhussain79

Payouts due:

Issue Reporter: $250 @ayazhussain79
Contributor: $1000 @pradeepmdk
Contributor+: $1000 @eVoloshchak

Eligible for 50% #urgency bonus? No

Upwork job is here.

@eVoloshchak

$1,000 payment approved for @eVoloshchak based on BZ summary.

@kadiealexander

@kadiealexander, this one can be closed I think

@kadiealexander

@kadiealexander could you please approve the payment on upwork

@ayazhussain79

@ayazhussain79 please apply in Upwork

@kadiealexander

@kadiealexander offer already accepted, sent you message on upwork

Navigation Menu

Repository navigation

[Awaiting payment] [$1000] After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #24246

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

77 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Awaiting payment] [$1000] After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #24246

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 8, 2023

melvin-bot commented on Aug 8, 2023

Bug0 Triage Checklist (Main S/O)

kadiealexander commented on Aug 8, 2023

melvin-bot commented on Aug 8, 2023

melvin-bot commented on Aug 8, 2023

melvin-bot commented on Aug 8, 2023

dukenv0307 commented on Aug 8, 2023

melvin-bot commented on Aug 8, 2023

77 remaining items

melvin-bot commented on Sep 11, 2023

eVoloshchak commented on Sep 26, 2023

eVoloshchak commented on Sep 26, 2023

eVoloshchak commented on Sep 26, 2023

pradeepmdk commented on Sep 30, 2023

kadiealexander commented on Oct 5, 2023

JmillsExpensify commented on Oct 5, 2023

eVoloshchak commented on Oct 26, 2023

ayazhussain79 commented on Nov 3, 2023

kadiealexander commented on Nov 5, 2023

ayazhussain79 commented on Nov 6, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions