[$1000] [HOLD for payment 2023-08-14] Dev: Offline Indicator duplicate

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click FAB
2. Request money
3. Turn off network, Observe that offline Indicator appears 2 times

Expected Result:

offline Indicator only appears 1 times

Actual Result:

offline Indicator appears 2 times

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• [x ] Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

rpreplay_final1691025997.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691026269347159?thread_ts=1691026269.347159&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ea26026f1b18139
• Upwork Job ID: 1691534812625043456
• Last Price Increase: 2023-08-15

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @namhihi237

Please re-state the problem that we are trying to solve in this issue.

Offline Indicator only appears 1 time in request money tab

What is the root cause of that problem?

In the request money manual screen, we have 2 nested ScreenWrapper. That why it's show 2 times

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 79 to 83 in 2f750ad

	<ScreenWrapper includeSafeAreaPaddingBottom={false}>
	{({safeAreaPaddingBottomStyle}) => (
	<FullPageNotFoundView shouldShow={!IOUUtils.isValidMoneyRequestType(iouType)}>
	<DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>
	<View style={[styles.flex1, safeAreaPaddingBottomStyle]}>

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 111 in 2f750ad

<MoneyRequestAmount route={props.route} />

App/src/pages/iou/steps/MoneyRequestAmount.js

Lines 424 to 429 in 2f750ad

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	onEntryTransitionEnd={focusTextInput}
	>
	{({safeAreaPaddingBottomStyle}) => (
	<View style={[styles.flex1, safeAreaPaddingBottomStyle]}>

What changes do you think we should make in order to solve the problem?

We should add shouldShowOfflineIndicator = {false} and remove safeAreaPaddingBottomStyle for ScreenWrapper in MoneyRequestAmount

            <ScreenWrapper
                includeSafeAreaPaddingBottom={false}
                onEntryTransitionEnd={focusTextInput}
                shouldShowOfflineIndicator = {false}
            >
             <View style={[styles.flex1]}>

What alternative solutions did you explore? (Optional)

N/A

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.