Repository navigation
[HOLD for payment 2024-07-10] [$1000] Double click enter to select value on pronouns and timezone edit pages navigates "back" twice #24074
Description
Activity
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Updated Proposal
Please re-state the problem that we are trying to solve in this issue.
Double enter click to select value on pronouns and timezone navigates user to main page/main settings page
What is the root cause of that problem?
navigation.goBack()is wrong. When current active route is/settings/profileand we callnavigation.goBack('settings/profie'), it goes to back/settings.For this reason, when we are on
Pronouns Select Pageand clickEnterkey twice, it callsnavigation.goBack('settings/profie')twice, but it goes to/settings/profile, and/settingsWhat changes do you think we should make in order to solve the problem?
- Update goBack method, this will prevent to goBack to current route.
if (!canNavigate('goBack') || isActiveRoute(fallbackRoute)) { return; }
- And Update updatePronouns, so we will prevent to update pronouns to empty.
In this line, if new pronouns is same as current pronouns, it passes empty string inupdatePronouns, so if pronouns is empty, we can perform goBack action only.
function updatePronouns(pronouns) { if (pronouns !== '') { API.write(...) } Navigation.goBack(ROUTES.SETTINGS_PROFILE); }
What alternative solutions did you explore? (Optional)
We can update
canNavigatelike this:function canNavigate(methodName, params = {}) { if (navigationRef.isReady() && !isActiveRoute(params['route'])) { return true; } Log.hmmm(`[Navigation] ${methodName} failed because navigation ref was not yet ready`, params); return false; }
And, update
goBackfunction like this:if (!canNavigate('goBack', {route: fallbackRoute})) { return; }
Ah, this got assigned to me while I was OoO. Sorry for the delay! I can reproduce this one on desktop as well, so ticked that platform off and removed the
needs reproductionlabel.I'd quite like an opinion from @mountiny on the expected result here. I don't really see the real world use of "multi-tapping" enter to go back multiple pages in the nav stack, whether that be two, three or ten pages. So IMO, we should just go back the once (because that's the behaviour after the selection on the page you're pushed to). What do you think?
@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
176 remaining items
I updated the formatting. But I can't list down steps for each page as each has separate functionality. The main step or interaction is mentioned in point 1. If the page has a selection list of options, try clicking it multiple times.
Hope this is sufficient.
But I can't list down steps for each page as each has separate functionality.
I thought we agreed on just the one, so we can focus on pronouns or something?
I think we just need one page like PronounsPage -> /settings/profile/pronouns
Reacted by parasharrajat@trjExpensify Updated.
Cool done, closing!
Hi @trjExpensify, @mountiny, @parasharrajat is this issue eligible for reporting bonus?
Oh yeah, this is old and I didn't spot the
reportedBy. So yes, I believe this is still eligible for $50 for the bug report. Are you still on Upwork?Thanks @trjExpensify, Yes I am still on upwork, here is my profile link
https://www.upwork.com/freelancers/~016c7b8ae165dc0bda
Actually the issue was created before 31st August 2023 (the deadline after which we changed reporting bonus from 250 to 50 dollars) but at this stage of the project, I will be happy with whatever you decide.Yep, that makes sense. We honour those.
Payment summary as follows:
- $250 to @dhanashree-sawant for the bug report
Offer sent!
Many Thanks @trjExpensify, I have accepted the offer.
Paid, closing.
Payment requested as per #24074 (comment)
$1,000 approved for @parasharrajat
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Note: Same results on the
timezoneedit selection page.Expected Result:
Use should only navigate back the one page in the nav stack when making a selection on the edit page.
Actual Result:
"Multi-tapping" is recognised and navigates back as many pages as you press enter. E.g twice = two pages, three times = three pages etc.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.47-3
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
double.enter.causes.double.back.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690794214667299
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @trjExpensify