[HOLD for checklist] [$1000] Web - Pointer cursor is displayed on deleted member of workspace when deleted in offline mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Open any workspace
5. Open members
6. If only 1 member then invite few members and switch off the internet
7. On members page, remove any member
8. Hover on removed member and observe that pointer cursor is displayed (We display not-allowed cursor on deleted items throughout the app), in case member is not visible, go back and reopen members

Expected Result:

App should display 'not-allowed' cursor on deleted item deleted in offline mode

Actual Result:

App displays 'pointer' cursor on deleted member deleted in offline mode on workspace members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pointer.cursor.on.deleted.workspace.member.mp4

Recording.4010.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690617307322089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b2a9bab227bac96
• Upwork Job ID: 1686036911311564800
• Last Price Increase: 2023-07-31
• Automatic offers:
• fedirjh | Reviewer | 25901002
• ginsuma | Contributor | 25901003
• dhanashree-sawant | Reporter | 25901006

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pointer cursor is displayed on deleted member of workspace when deleted in offline mode.

What is the root cause of that problem?

Currently, we don't disable the item when it has delete pendingAction.

App/src/pages/workspace/WorkspaceMembersPage.js

Line 297 in eb02006

const disabled = props.session.email === item.login || item.role === 'admin';

What changes do you think we should make in order to solve the problem?

Change LOC above to:

 const disabled = props.session.email === item.login || item.role === 'admin' || item.pendingAction === 'delete'; 

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b2a9bab227bac96

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@ginsuma's proposal looks straightforward fix to me. Let's proceed with it.

🎀 👀 🎀 C+ reviewed