[WAITING ON CHECKLIST] [$1000] Web - Secondary contact method transition bug - clicking on a contact method that has yet to be validated opens the magic code input (validation) page with a sped up animation

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > profile > contact method
2. Click on new contact method
3. Enter an email address
4. Click add
5. Click on the email address you just entered
6. Observe how the transition animation to the magic code input (validation) page is sped up/doesn’t work properly. If you look closely you can see that the text (sometimes) wobbles

Expected Result:

The page transition should be animated like other page transitions, without it being sped up.

Actual Result:

The page transition appears to not be animated/is sped up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.3.44.0
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-24.at.20.29.13.mov

Expensify/Expensify Issue URL:
Issue reported by: @joh42
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690229176544109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b86e6c6c9fa20453
• Upwork Job ID: 1684009715954917376
2023-07-26
• Automatic offers:
• joh42 | Contributor | 25814019
• joh42 | Reporter | 25814020

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal: @joh42
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690229176544109

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are trying to solve the sped up animation when the secondary contact method validation page is opened.

What is the root cause of that problem?

The root cause of the problem is that focus is given to the magic code text input instantly, before the transition animation has finished.

What changes do you think we should make in order to solve the problem?

The solution requiring the least amount of changes to the codebase would be to always pass shouldDelayFocus={true} from the BaseValidateCodeForm component to the MagicCodeInput component. Currently that is only passed as true for Android. Alternatively we could pass it as true for only Android and Chrome, but that would be more complex.

App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

Line 142 in beebb67

shouldDelayFocus={shouldDelayFocus}

That would be enough to solve this issue. However, while we're at it, we might want to improve the code a bit:

We can simplify the MagicCodeInput component by removing the following useEffect

App/src/components/MagicCodeInput.js

Lines 156 to 176 in 2c15e97

	useEffect(() => {
	if (!props.autoFocus) {
	return;
	}
	let focusTimeout = null;
	if (props.shouldDelayFocus) {
	focusTimeout = setTimeout(() => inputRefs.current[0].focus(), CONST.ANIMATED_TRANSITION);
	} else {
	inputRefs.current[0].focus();
	}
	return () => {
	if (!focusTimeout) {
	return;
	}
	clearTimeout(focusTimeout);
	};
	// We only want this to run on mount
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

Instead we could pass shouldDelayFocus along to the first TextInput component, as opposed to not passing autoFocus if shouldDelayFocus is true:

App/src/components/MagicCodeInput.js

Lines 327 to 329 in 2c15e97

	<TextInput
	ref={(ref) => (inputRefs.current[index] = ref)}
	autoFocus={index === 0 && props.autoFocus && !props.shouldDelayFocus}

The TextInput component already supports the shouldDelayFocus prop, so removing that redundant functionality from MagicCodeInput would make the code a bit DRYer.

App/src/components/TextInput/BaseTextInput.js

Lines 67 to 70 in a656c82

	if (props.shouldDelayFocus) {
	focusTimeout = setTimeout(() => input.current.focus(), CONST.ANIMATED_TRANSITION);
	return;
	}

What alternative solutions did you explore? (Optional)

There is currently an ongoing Slack discussion regarding a general approach to solving this issue. The two alternate solutions to knowing when we should set focus is to use either InteractionManager.runAfterInteractions or onTransitionEnd. Both of those would require more changes than using the already implemented shouldDelayFocus. I nonetheless think we should wait for that discussion to conclude, and then consider if we should go with the solution that is deemed optimal even if it is more complex to implement.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b86e6c6c9fa20453

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)