[HOLD for payment 2023-08-16][$1000] Web - App displays pointer cursor on blank spaces on PDF

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any PDF
4. Hover on empty white spaces on PDF and observe that it displays pointer cursor instead of normal cursor

Expected Result:

App should display normal cursor on blank spaces in PDF as those areas are not clickable

Actual Result:

App displays pointer cursor on blank spaces in PDF even though those areas are not clickable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pointer.cursor.on.PDF.blank.spaces.mp4

Recording.3867.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690103358925329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0176c574f2dce1209d
• Upwork Job ID: 1684765761901330432
• Last Price Increase: 2023-07-28
• Automatic offers:
• hungvu193 | Contributor | 25868501
• dhanashree-sawant | Reporter | 25868503

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - App displays pointer cursor on blank spaces on PDF

What is the root cause of that problem?

We're wrapping our PDFView inside a PressableWithFeedback incase there's a onPress props, but our onPress props has default props () => {} so this condition is always true, make our pdfview always render inside a PressableWithoutFeedback.

App/src/components/PDFView/index.js

Lines 168 to 181 in 82669ae

	render() {
	return this.props.onPress ? (
	<PressableWithoutFeedback
	onPress={this.props.onPress}
	style={[styles.flex1, styles.flexRow, styles.alignSelfStretch]}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.IMAGEBUTTON}
	accessibilityLabel={this.props.fileName || this.props.translate('attachmentView.unknownFilename')}
	>
	{this.renderPDFView()}
	</PressableWithoutFeedback>
	) : (
	this.renderPDFView()
	);
	}

What changes do you think we should make in order to solve the problem?

Solution 1:

Add styles.cursorPointer to our PressableWithFeedback.

Solution 2:

Since we only pass onPress to our AttachmentView with this.canUseTouchScreen is true, we can change the condition here to:

return this.props.onPress && this.canUseTouchScreen ? () : ()

Solution 3:

Change the default props of onPress function inside PDFView/index.js to undefined.

What alternative solutions did you explore? (Optional)

N.A

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0176c574f2dce1209d

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[adelekennedy]

I can reproduce, let's polish