[$1000] Money request page crash after sign in

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign out if you are signed in
2. Go to staging.new.expensify.com/request/new
3. Login

Expected Result:

App crash

Actual Result:

App should not crash

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-22.at.17.04.45.mov

Recording.1320.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690017033035589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c96f9a061c08188b
• Upwork Job ID: 1683620832387874816
2023-07-24
• Automatic offers:
• bernhardoj | Contributor | 25856547
• bernhardoj | Reporter | 25856549

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crash when opening the money request page after signing in

What is the root cause of that problem?

The crash happens because in TextInputWithCurrencySymbol, selectedCurrencyCode prop is marked as required, but it got undefined.

App/src/components/TextInputWithCurrencySymbol.js

Lines 23 to 24 in b7d17e0

	/** Currency code of user's selected currency */
	selectedCurrencyCode: PropTypes.string.isRequired,

The selectedCurrencyCode is passed down from MoneyRequestAmountPage with the value from props.iou.currency (Onyx IOU). We have a defaultProps that set the currency to USD.

App/src/pages/iou/steps/MoneyRequestAmountPage.js

Lines 67 to 72 in b7d17e0

	iou: {
	id: '',
	amount: 0,
	currency: CONST.CURRENCY.USD,
	participants: [],
	},

defaultProps will be used if iou is undefined. The problem is, Onyx IOU itself has a default value.

App/src/setup/index.js

Lines 31 to 39 in b7d17e0

	initialKeyStates: {
	// Clear any loading and error messages so they do not appear on app startup
	[ONYXKEYS.SESSION]: {loading: false},
	[ONYXKEYS.ACCOUNT]: CONST.DEFAULT_ACCOUNT_DATA,
	[ONYXKEYS.NETWORK]: {isOffline: false},
	[ONYXKEYS.IOU]: {
	loading: false,
	error: false,
	},

So, when we sign in, we have an IOU object of {loading, error} which will ignore the defaultProps in MoneyRequestAmountPage, thus the currency is undefined.
This issue is a regression of my PR here #17964. Previously, we use lodashGet to get the currency and default to USD. Here is the commit of using the lodashGet https://github.com/Expensify/App/pull/17964/commits/4fdf587c1fca3cc147f7184c1bf765bcd2cf5ee5#diff-879f243892ee617d3ea9b[…]91d2bec3eb12b90f09aac6a05a
but somehow I remove it in a later commit.

What changes do you think we should make in order to solve the problem?

I think that's okay to not use lodashGet and instead we can remove the default value of Onyx IOU.
(remove this)

App/src/setup/index.js

Lines 36 to 39 in b7d17e0

	[ONYXKEYS.IOU]: {
	loading: false,
	error: false,
	},

Both loading and error are not being used anywhere.

What alternative solutions did you explore? (Optional)

Make selectedCurrencyCode in TextInputWithCurrencySymbol optional and set USD as the default prop of selectedCurrencyCode.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[JmillsExpensify]

Interestingly, I don't get a crash for this case though I do see this.

[JmillsExpensify]

In any case, I think that's largely a detail given that it's consistent with your video. I'm going to triage as a result.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c96f9a061c08188b

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)