[Awaiting C+ payment confirmation] [HOLD for payment 2023-08-16] [$1000] IOS - Getting console warning on Contact methods page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App and Go to Settings
2. Go to Profile > Press Contact Method

Expected Result:

There should be no console error on navigating to Contact Methods Page.

Actual Result:

On the Contact Methods Page Getting this console warning, *Warning: Failed prop type: The prop innerRef is marked as required in PressableWithDelayToggle, but its value is null

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.42-6
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

contact-method-console-error.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689664358693289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7dbc8ab0e657b1c
• Upwork Job ID: 1681447597214900224
2023-07-18
• Automatic offers:
• | | 0
• jayeshmangwani | Reporter | 25676805

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Getting console warning on Contact methods page

What is the root cause of that problem?

In PressableWithDelayToggle Component we passed the innerRef as required prop and when forwardRef pass the null ref then we get the console warning

App/src/components/Pressable/PressableWithDelayToggle.js

Lines 14 to 16 in 4e49206

	const propTypes = {
	/** Ref passed to the component by React.forwardRef (do not pass from parent) */
	innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,

What changes do you think we should make in order to solve the problem?

1. Here at defaultProps we should add the fallback value of innerRef

App/src/components/Pressable/PressableWithDelayToggle.js

Lines 59 to 69 in 4e49206

	const defaultProps = {
	text: '',
	textChecked: '',
	tooltipText: '',
	tooltipTextChecked: '',
	styles: [],
	textStyles: [],
	iconStyles: [],
	icon: null,
	inline: true,
	iconChecked: Expensicons.Checkmark,

    innerRef: () => {},

2. And innerRef prop does not have to be the required param, as here in BaseMiniContextMenuItem we are passing the ref to Pressable and it is not the required, and here in PressableWithDelayToggle Component also we are passing ref to Pressable

App/src/components/BaseMiniContextMenuItem.js

Lines 33 to 36 in f74512d

	/**
	* A ref to forward to the Pressable
	*/
	innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.object]),

We should remove the isRequired from the innerRef propTypes on PressableWithDelayToggle

What alternative solutions did you explore? (Optional)

none

[trjExpensify]

I don't have a dev environment to check for console logs on iOS. @aimane-chnaif I suspect maybe something to do with this migration of the component: #20601

Will move this on for a proposal review and input from C+!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a7dbc8ab0e657b1c

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.