[HOLD for payment 2023-08-14] [$1000] Chat - Clicking Outside Link in Link Preview Should Not Open the Link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Login to the application and navigate to any chat.
2. Send a link (e.g., www.google.com) in the chat.
3. In the link preview, click outside the link (next to it) instead of directly on the link itself.

Expected Result:

Clicking outside the link in the link preview should not open the corresponding link.

Actual Result:

When clicking next to the link in the link preview, it opens the corresponding link in a new tab or the default browser,

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

claick-outside-link.mov

Recording.3680.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689435841926949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019285d8fb1003132d
• Upwork Job ID: 1681656254083117056
• Last Price Increase: 2023-07-26

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

by : @ahmdshrif

Please re-state the problem that we are trying to solve in this issue.

Clicking next to the link preview click on the link

What is the root cause of that problem?

By default, we will set align-self or align-items on the parent to stretch to the View, which stretches the
textLink to take the parent width.

What changes do you think we should make in order to solve the problem?

we need to add self-alignment to start or Baseline the text-link style here

App/src/pages/home/report/LinkPreviewer.js

Lines 108 to 114 in b9508b6

	<TextLink
	fontSize={variables.fontSizeNormal}
	style={[styles.pv2, StyleUtils.getTextColorStyle(colors.blueLinkPreview)]}
	href={url}
	>
	{title}
	</TextLink>

style={[styles.pv2, StyleUtils.getTextColorStyle(colors.blueLinkPreview), styles.alignSelfStart]}

What alternative solutions did you explore? (Optional)

add a container with styles.alignItemsBaseline (or styles.alignItemsStart) to the text link
or for the preview container.

Result :

fix-click-outside-link.mov

[JmillsExpensify]

This is not a bug in my opinion, as we're still building out the feature and it's debatable how this new feature should work. That said, I think I agree that within the link preview, only the hyperlink within the preview should be clickable. I'll triage.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019285d8fb1003132d

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.