[HOLD for payment 2023-08-16] [$1000] Login - 'sign in here' on expired magic code page redirects to chat which loads infinitely

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Copy the magic code link
3. Paste the link in a incognito tab
4. Tap just sign in here

Expected Result:

User is redirected to LHN after successful login

Actual Result:

User is redirected to the conversation and the conversation loads infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124872_Screen_Recording_20230712_175146_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d8001b7ff3552709
• Upwork Job ID: 1679249935481970688
2023-07-19
• Automatic offers:
• | | 0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

I'm not able to follow these steps -asking for some guidance from QA - https://expensify.slack.com/archives/C9YU7BX5M/p1689187723167809

[Christinadobrzyn]

I can't reproduce through Browserstack because it doesn't have incognito but it's been tested with QA so moving forward

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d8001b7ff3552709

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - 'sign in here' on expired magic code page redirects to chat which loads infinitely

What is the root cause of that problem?

When users click sign in here, we call API SignInUserWithLink

=> cachedAutoAuthState = "just-signed-in"

We're navigating to /r instead of '' (LHN screen)

App/src/pages/ValidateLoginPage/index.website.js

Line 76 in 451096b

Navigation.navigate(ROUTES.REPORT);

What changes do you think we should make in order to solve the problem?

Change this line

App/src/pages/ValidateLoginPage/index.website.js

Line 76 in 451096b

Navigation.navigate(ROUTES.REPORT);

to Navigation.navigate();

Another place that need to fix

App/src/pages/ValidateLoginPage/index.website.js

Lines 79 to 86 in 173b58e

	useEffect(() => {
	if (login || !cachedAccountID || !is2FARequired) {
	return;
	}
	// The user clicked the option to sign in the current tab
	Navigation.navigate(ROUTES.REPORT);
	}, [login, cachedAccountID, is2FARequired]);

Result

Screen.Recording.2023-07-13.at.14.57.16.mov