[HOLD for payment 2023-08-01] [$1000] Date of birth - Year list is scrolled back to current selection when keyboard disappears

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Go to Settings > Profile > Personal details > Date of birth
Tap on the year to open year list
With the keyboard on, scroll up the list

Expected Result:

When the keyboard disappears, the year list will stay at where it is scrolled up to

Actual Result:

When the keyboard disappears, the year list is scrolled back to the current selection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124289_screen_recording_20230712_005515_new_expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01570faed600b40bf8
Upwork Job ID: 1679174470293659648
Last Price Increase: 2023-07-12

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

DoB year list is scrolled back to current selection when keyboard disappears

What is the root cause of that problem?

The root cause of the issue is that we're scrolling to the focused index whenever the layout changes. On mweb, whenever the keyboard appears, it triggers a layout change which in turn cause the list to scroll back to focused index. This can be seen here.

What changes do you think we should make in order to solve the problem?

We should remove this line and scroll only on the first mount. This can be done by either using initialScrollIndex on the SectionList here or by using useEffect that scrolls only on the first mount given that the list reference is available.

What alternative solutions did you explore? (Optional)

None

Job added to Upwork: https://www.upwork.com/jobs/~01570faed600b40bf8

@lschurr

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@fedirjh

Hi @fedirjh - could you review the proposal on this one?

Reviewing label has been removed, please complete the "BugZero Checklist".

@allroundexperts

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: scroll date of birth year list on first mount only #23079

If no regressions arise, payment will be issued on 2023-08-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@allroundexperts does not require payment (Eligable for Manual Requests)
@fedirjh requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts / @fedirjh] Determine if we should create a regression test for this bug.
[@allroundexperts / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fedirjh

Summarizing payments for this issue:

Contributor+: @fedirjh $1500 (to be paid in Upwork)
Contributor: @allroundexperts $1500 (please request via NewDot)

@fedirjh

@fedirjh @allroundexperts could you work on the checklist and determine if we need a new regression test?

@lschurr

@lschurr I think you have reversed the roles here. I was the contributor and @fedirjh was the C+ here.

Oops! Updated the comment.

@allroundexperts

Do we need a regression test @allroundexperts @fedirjh?

BugZero Checklist:

Link to the PR: refactor: SelectionListRadio #21048
Link to comment: refactor: SelectionListRadio #21048 (comment)
Link to discussion: N/A Nothing to add to the checklist, this bug could have been caught during the PR review.
Determine if we should create a regression test for this bug: ✅ I think we should require a regression test for this bug as it affects the UX.

Regression Test Proposal

Open the App on mweb Chrome.
Go to Settings > Profile > Personal details > Date of birth
Tap on the year to open the year list
With the keyboard on, scroll up the list
Verify that the list does not scroll back to the focused index.

Do we agree 👍 or 👎

Added the regression test request. Closing!

@allroundexperts

Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-01] [$1000] Date of birth - Year list is scrolled back to current selection when keyboard disappears #22689

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

19 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-08-01] [$1000] Date of birth - Year list is scrolled back to current selection when keyboard disappears #22689

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jul 11, 2023

melvin-bot commented on Jul 11, 2023

Bug0 Triage Checklist (Main S/O)

allroundexperts commented on Jul 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 12, 2023

melvin-bot commented on Jul 12, 2023

melvin-bot commented on Jul 12, 2023

lschurr commented on Jul 14, 2023

19 remaining items

melvin-bot commented on Jul 25, 2023

melvin-bot commented on Jul 25, 2023

melvin-bot commented on Jul 25, 2023

lschurr commented on Jul 31, 2023

lschurr commented on Jul 31, 2023

allroundexperts commented on Aug 1, 2023

lschurr commented on Aug 1, 2023

lschurr commented on Aug 1, 2023

fedirjh commented on Aug 1, 2023

BugZero Checklist:

lschurr commented on Aug 1, 2023

JmillsExpensify commented on Aug 2, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions