Repository navigation
Web - Workspace name missing after #announce or #admins #22647
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Create a workspace if not created
- Check workspace name in LHN
Expected Result:
It should show workspace name after #announce or #admins to identify policy
Actual Result:
The workspace name missing after #announce or #admins
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-11.at.6.42.05.PM.mov
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689081311895289
Activity
OSBotify commentedon Jul 11, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 11, 2023
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.jakub-trzebiatowski commentedon Jul 11, 2023
This is from #20512. The specific commit is
6bc4f8c27c658fa4836b13d687a75182b93b11b6. The change looks intentional, but I cannot understand the reasoning.0xmiroslav commentedon Jul 11, 2023
This is intentional. I think we should update test rail so that QA team won't get confused.
cc: @grgia
jakub-trzebiatowski commentedon Jul 11, 2023
@0xmiroslav @grgia Pragmatically speaking, how is the user expected to know which workspace is which?
My workspaces look like this now:
I know that we, the contributors and testers, are not typical real users, but now I'm basically left with colors to distinguish my workspaces.
And I'm colorblind.
0xmiroslav commentedon Jul 11, 2023
yup, after this refactor, all avatars are quite similar and hard to distinguish which one is which chat.
In addition to color, tooltip is the only way to find which workspace, though still not possible on mobile.
I think team already planned to update.
0xmiroslav commentedon Jul 11, 2023
cc: @shawnborton
shawnborton commentedon Jul 11, 2023
Keep in mind that most people will only have one workspace, and people can also upload a custom avatar.
bondydaa commentedon Jul 11, 2023
coolio sounds like this isn't a blocker and is expected then.
Once #20512 goes to prod it'll post the comment about updating testing steps so let's make sure we get those updated.
Going to close this out for now.