[$1000] Web - The clickable area of the header of the assigned task chat and thread message chat is stretched beyond the link text.

@Tushu17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Send a message and open a thread for that message, or Navigate to the assigned task chat.
Hover over the header of the chat.
Observe that the clickable area is stretched beyond the link text.

Expected Result:

The clickable area shouldn't be stretched beyond the blue link text.

Actual Result:

The clickable area is stretched beyond the link text.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.38-0.
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3502.mp4

Screen.Recording.2023-07-07.at.4.32.09.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688727698163079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015979d65d6bb3946e
Upwork Job ID: 1678406630575710208
Last Price Increase: 2023-07-10

Proposal

Please re-state the problem that we are trying to solve in this issue.

The clickable area of the header of the assigned task chat and thread message chat is stretched beyond the link text.

What is the root cause of that problem?

The PressableWithoutFeedback display in default style as a block and align self stretch

App/src/components/AvatarWithDisplayName.js

Lines 94 to 107 in 58f663a

    
           <PressableWithoutFeedback 
        
               onPress={() => { 
        
                   Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID)); 
        
               }} 
        
               accessibilityLabel={subtitle} 
        
               accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK} 
        
           > 
        
               <Text 
        
                   style={[styles.optionAlternateText, styles.textLabelSupporting, styles.link]} 
        
                   numberOfLines={1} 
        
               > 
        
                   {parentNavigationSubtitle} 
        
               </Text> 
        
           </PressableWithoutFeedback>

What changes do you think we should make in order to solve the problem?

We need to add style style={[styles.alignSelfStart]} to PressableWithoutFeedback here

App/src/components/AvatarWithDisplayName.js

Lines 94 to 100 in 58f663a

    
           <PressableWithoutFeedback 
        
               onPress={() => { 
        
                   Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID)); 
        
               }} 
        
               accessibilityLabel={subtitle} 
        
               accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK} 
        
           >

What alternative solutions did you explore? (Optional)

N/A

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

The clickable area of the header of the assigned task chat and thread message chat is stretched beyond the link text.

What is the root cause of that problem?

In this PR (see line 196) styles that are needed for limiting the width of parent chat (parentNavigationSubtitle) were removed by mistake from the HeaderView component.

What changes do you think we should make in order to solve the problem?

We need to add the following styles back to PressableWithoutFeedback after line 196 in the HeaderView component -

style={[styles.alignSelfStart, styles.mw100]}

If we just add alignSelfStart then text will overflow on small screens as visible in result video below so we need to add mw100 (max-width: 100%) too.

What alternative solutions did you explore? (Optional)

NA

Result -

Screen.Recording.2023-07-08.at.3.42.35.AM.mov

Bug report looks good!

Job added to Upwork: https://www.upwork.com/jobs/~015979d65d6bb3946e

@slafortune

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

@allroundexperts

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

Seems we already have a PR for it.

Navigation Menu

Repository navigation

[$1000] Web - The clickable area of the header of the assigned task chat and thread message chat is stretched beyond the link text. #22455

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<PressableWithoutFeedback
	onPress={() => {
	Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID));
	}}
	accessibilityLabel={subtitle}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK}
	>
	<Text
	style={[styles.optionAlternateText, styles.textLabelSupporting, styles.link]}
	numberOfLines={1}
	>
	{parentNavigationSubtitle}
	</Text>
	</PressableWithoutFeedback>

[$1000] Web - The clickable area of the header of the assigned task chat and thread message chat is stretched beyond the link text. #22455

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

ahmedGaber93 commented on Jul 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 7, 2023

melvin-bot commented on Jul 7, 2023

Bug0 Triage Checklist (Main S/O)

Nikhil-Vats commented on Jul 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

slafortune commented on Jul 10, 2023

melvin-bot commented on Jul 10, 2023

melvin-bot commented on Jul 10, 2023

melvin-bot commented on Jul 10, 2023

Pujan92 commented on Jul 10, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions