[HOLD for payment 2023-07-17] [$1000] Remove usage of getReportIDFromRoute

Problem
We missed some instances of _ reportIDFromRoute_ during the navigation refactor, which caused a regression.

Solution
Remove them

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014254ae0a9d055feb
Upwork Job ID: 1676859624120598528
Last Price Increase: 2023-07-06

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~014254ae0a9d055feb

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[navigation-refactor] Remove getReportIDFromRoute helper function #21702

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@Gonals

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Just some forgotten usage. I don't think we need this

[@Gonals] The PR that introduced the bug has been identified. Link to the PR:
[@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Gonals] Determine if we should create a regression test for this bug.
[@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Gonals

@Gonals what is required from me here? Does anyone need to be paid or can I unassign myself. Sorry, but I'm a bit confused!

I think you are all good!

@Gonals

@Gonals Eep! 4 days overdue now. Issues have feelings too...

@Gonals

@Gonals Still overdue 6 days?! Let's take care of this!

@Gonals

@Gonals 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

I think we can close this

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-17] [$1000] Remove usage of getReportIDFromRoute #22326

Bug0 Triage Checklist (Main S/O)

18 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-07-17] [$1000] Remove usage of getReportIDFromRoute #22326

Description

Activity

melvin-bot commented on Jul 6, 2023

melvin-bot commented on Jul 6, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Jul 6, 2023

18 remaining items

melvin-bot commented on Jul 10, 2023

melvin-bot commented on Jul 10, 2023

melvin-bot commented on Jul 10, 2023

flaviadefaria commented on Jul 18, 2023

Gonals commented on Jul 19, 2023

melvin-bot commented on Jul 24, 2023

melvin-bot commented on Jul 26, 2023

melvin-bot commented on Jul 28, 2023

Gonals commented on Jul 31, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions