[HOLD for payment 2023-08-14] [$1000] Web - Appropriate message is not shown when drag&drop a folder.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat.
2. Drag & drop a folder a size less than 24MB and Greater than 240bytes.

Expected Result:

We should show an error message that uploading folders is not supported.

Actual Result:

We show the error: The attachment size must be greater than 240 bytes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-4
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test58_Dragdropfolder-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688504637490979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012e40ccd48a35f18f
• Upwork Job ID: 1678535202129506304
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Appropriate message is not shown when drag&drop a folder.

What is the root cause of that problem?

When we drag file it will have file object info as shown here in debug.

When we drag folder it will have file object info as shown here in debug.

As we can see for the folder type property is empty string and size belongs to folder size.

So when we drop content, we just check size but we do not have any checking to detect that given item is folder or file, so it will just check size and show message accordingly.

Here is the code we are checking for file size etc.

App/src/components/AttachmentModal.js

Lines 172 to 202 in f08ab19

	const isValidFile = useCallback(
	(_file) => {
	const {fileExtension} = FileUtils.splitExtensionFromFileName(lodashGet(_file, 'name', ''));
	if (_.contains(CONST.API_ATTACHMENT_VALIDATIONS.UNALLOWED_EXTENSIONS, fileExtension.toLowerCase())) {
	const invalidReason = props.translate('attachmentPicker.notAllowedExtension');
	setIsAttachmentInvalid(true);
	setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.wrongFileType'));
	setAttachmentInvalidReason(invalidReason);
	return false;
	}
	if (lodashGet(_file, 'size', 0) > CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE) {
	setIsAttachmentInvalid(true);
	setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.attachmentTooLarge'));
	setAttachmentInvalidReason(props.translate('attachmentPicker.sizeExceeded'));
	return false;
	}
	if (lodashGet(_file, 'size', 0) < CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE) {
	setIsAttachmentInvalid(true);
	setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.attachmentTooSmall'));
	setAttachmentInvalidReason(props.translate('attachmentPicker.sizeNotMet'));
	return false;
	}
	return true;
	},
	// eslint-disable-next-line react-hooks/exhaustive-deps
	[props.translate],
	);

What changes do you think we should make in order to solve the problem?

We need to add checking that dropped item is folder or not. So if dropped item is folder it will have file.type as empty, so we can put condition as shown code below:

const isValidFile = useCallback( 
     (_file) => { 
        // *** ADD THIS CONDITION ***
        // If dropped item is folder then show error.
        if (_file.type === '') {
            setIsAttachmentInvalid(true);
            setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.folderNotAllowed'));
            setAttachmentInvalidReason(props.translate('attachmentPicker.folderNotAllowedMessage'));
            return false;
        }
        ...
     }, 
     // eslint-disable-next-line react-hooks/exhaustive-deps 
     [props.translate], 
 ); 

We have to also add corresponding translation for en and es.

en.js

attachmentPicker: {
    ...
    folderNotAllowed: 'Folder not allowed.', // *** ADD THIS ***
    folderNotAllowedMessage: 'Uploading folders is not allowed.', // *** ADD THIS ***
},

es.js

attachmentPicker: {
    ...
    folderNotAllowed: 'Carpeta no permitida.',
    folderNotAllowedMessage: 'No se permite subir carpetas.',
},

Note: We can adjust the message text copy as per need. At present I put folder not allowed message for explanation purpose.

What alternative solutions did you explore? (Optional)

None

Result

22306-FolderNotAllowed.mov

[sakluger]

I agree that this is a bug, we do not support folder upload and should return an error if a user tries uploading a folder via drag and drop.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012e40ccd48a35f18f