[HOLD for payment 2023-07-20] [$1000] Web - Text area is misaligned in close account page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > security > close account
2. Hover over the first input placeholder and notice the cursor
3. Hover over the second input placeholder and notice the cursor
4. Open dev tools and click on inspect
5. Hover over the first input field

Expected Result:

The cursor should not change to pointer when hovering over the first text area just like it doesn't on the second text area.

Actual Result:

The cursor turns to pointer while hovering over the first input field place holder and the while inspecting the text area it is misaligned and the text area starts halfway through the first placeholder.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-01.17.47.16.mp4

Recording.3363.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688223038310559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a57cf140b61f86f
• Upwork Job ID: 1675942585383223296
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hnkuanx]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor is shown as pointer when hover over label of Multiline text input.

What is the root cause of that problem?

For the "Enter message here" <textarea> input, there is no issue with its alignment since it should be below the "Enter message here" text <label> when it is shrink upon pressed.
It looks different compared to "Please type your default contact method" text input as that is not a multiline input, so it is just single <input> element without separate label and input area.

The cursor is showing as pointer on the multiline <label> because BaseTextInput uses PressableWithoutFeedback which has getCursorStyle from BaseGenericPressable that shows the cursor text only when it is within the <textarea>

App/src/components/Pressable/GenericPressable/BaseGenericPressable.js

Lines 18 to 28 in c0ece67

	const getCursorStyle = (isDisabled, isText) => {
	if (isDisabled) {
	return styles.cursorDisabled;
	}
	if (isText) {
	return styles.cursorText;
	}
	return styles.cursorPointer;
	};

When it is out of the textarea, the styling is default to pointer, which is a sensible default since the elements under Pressable should be pressable e.g. button

The same issue actually also happens user hover over the line at the bottom of the text input, regardless if it is multiline or not.

Video to illustrate the issue:

Screen.Recording.2023-07-02.at.9.12.24.AM.mov

What changes do you think we should make in order to solve the problem?

We should add pointerEvents="none" to

App/src/components/TextInput/BaseTextInput.js

Line 232 in c0ece67

<View>

in order to show the normal cursor when hover over text label and line at bottom.

Results :

Screen.Recording.2023-07-02.at.9.23.20.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010a57cf140b61f86f

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong cursor when hovering on the textinput outer boundary

What is the root cause of that problem?

Incorrect cursorPointer type used in PressableWithoutFeedback on BaseTextInput component. Currently the value is cursor.

What changes do you think we should make in order to solve the problem?

We can set PressableWithoutFeedback inside BaseTextInput cursor style to text.

We can set it directly to its style or use accessibilityRole="text" or role="text" in the PressableWithoutFeedback

App/src/components/TextInput/BaseTextInput.js

Lines 248 to 253 in 917c344

	<PressableWithoutFeedback
	onPress={onPress}
	focusable={false}
	accessibilityLabel={props.label}
	style={[props.autoGrowHeight && styles.autoGrowHeightInputContainer(textInputHeight, maxHeight), !isMultiline && styles.componentHeightLarge, ...props.containerStyles]}
	>

What alternative solutions did you explore? (Optional)

N/A