[HOLD for checklist] [$1000] Web - Pressing the Pin/Unpin option from the LHN context menu does not refocus the composer.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App and go to any chat
2. On LHN, Right click on any user's chat to Open the context menu
3. Press Pin/Unpin option

Expected Result:

After pressing on the pin/unpin then composer should be refocused, as the same happens After pressing on the mark as read/unread option from the LHN context menu

Actual Result:

After Pressing the pin/unpin option, Composer is not refocused.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pin-unpin-does-npt-focus.mov

Recording.3307.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687938349897719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc6f96ae79d98073
• Upwork Job ID: 1674685137307795456
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

from @jayeshmangwani

Please re-state the problem that we are trying to solve in this issue.

Pressing the Pin/Unpin option from the LHN context menu does not refocus the composer

What is the root cause of that problem?

On press of the Pin and Unpin buttons we only hide the Context Menu, we do not call the refocus of the Composer.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

What changes do you think we should make in order to solve the problem?

When we press the Pin and Unpin buttons, then we need to call the ReportActionComposeFocusManager.focus, like same, we do for Mark As Read button

Need to update this code at these two places

    hideContextMenu(false); // OLD
    hideContextMenu(true, ReportActionComposeFocusManager.focus); // NEW

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the Pin/Unpin option from the LHN context menu does not refocus the composer

What is the root cause of that problem?

On press of the Pin and Unpin buttons we only hide the Context Menu, we do not call the refocus of the Composer.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

What changes do you think we should make in order to solve the problem?

When we press the Pin and Unpin buttons, then we need to call the ReportActionComposeFocusManager.focus, like same, we do for Mark As Read button

Need to update this code at these two places

    hideContextMenu(false); // OLD
    hideContextMenu(true, ReportActionComposeFocusManager.focus); // NEW

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

[greg-schroeder]

Reviewing

[greg-schroeder]

Reproduced, seems like it should match the Read/Unread behavior to me

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc6f96ae79d98073

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.