[HOLD for payment 2023-08-21] [$2000] Hitting enter key on keyboard does not select a pronoun

@Nathan-Mulugeta

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open ND on android
Go to settings > Profile > Pronouns
Search a pronoun
Hit on Enter / tick mark key on keyboard
Observe the behavior
Open mWeb and do step 2 - 5

Expected Result:

The behavior on both mWeb and Android should be the same.

Actual Result:

On android hitting the enter key does nothing other than closing the keyboard, but on mWeb hitting the enter key on keyboard selects the searched pronoun

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.30-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230618_202315_Chrome.mp4

az_recorder_20230623_183852.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687109264930579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01763c040cae5d6f20
Upwork Job ID: 1673255740814970880
Last Price Increase: 2023-07-17

@conorpendergrast

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the "Submit" button is pressed on the virtual keyboard, the focused pronouns aren't selected.

What is the root cause of that problem?

While we subscribe to "Enter" key presses via KeyboardShortcut.subscribe, this doesn't work on Native.

What changes do you think we should make in order to solve the problem?

Minor changes should be done to the BaseOptionsSelector component.

We should extract the relevant logic and call it...

From the callback passed to KeyboardShortcut.subscribe
From the onSubmitEditing passed to TextInput

Extracted logic:

selectFocusedOption() {
    const focusedOption = this.state.allOptions[this.state.focusedIndex];
    if (!focusedOption || !this.props.isFocused) {
        return;
    }
    if (this.props.canSelectMultipleOptions) {
        this.selectRow(focusedOption);
    } else if (!this.state.shouldDisableRowSelection) {
        this.setState({shouldDisableRowSelection: true});
        let result = this.selectRow(focusedOption);
        if (!(result instanceof Promise)) {
            result = Promise.resolve();
        }
        setTimeout(() => result.finally(() => this.setState({shouldDisableRowSelection: false})), 500);
    }
}

Call from the KeyboardShortcut.subscribe callback:

this.unsubscribeEnter = KeyboardShortcut.subscribe(
    enterConfig.shortcutKey,
    () => {
        this.selectFocusedOption();
    },
    enterConfig.descriptionKey,
    enterConfig.modifiers,
    true,
    () => !this.state.allOptions[this.state.focusedIndex],
);

Call from the onSubmitEditing callback:

<TextInput
    // ...
    onChangeText={this.props.onChangeText}
    onSubmitEditing={()=> {
        this.selectFocusedOption();
    }}
    // ...
/>

My branch

We see the same behaviour in selecting timezone and currency (during a money request and split) too, by the way!

Timezone	Request - Currency	Split - Currency

Job added to Upwork: https://www.upwork.com/jobs/~01763c040cae5d6f20

@conorpendergrast

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

Reviewing label has been removed, please complete the "BugZero Checklist".

@rushatgabhane

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Select focused pronouns when the text input is submitted #24202

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@cubuspl42 requires payment
@rushatgabhane does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@rushatgabhane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@cubuspl42 / @rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[@cubuspl42 / @rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cubuspl42 / @rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cubuspl42 / @rushatgabhane] Determine if we should create a regression test for this bug.
[@cubuspl42 / @rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified. Link to the PR: Standardize arrow navigation in OptionsLists #7702
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/7702/files#r1293917132
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

created a manual request incl bonus ($3k) https://staging.new.expensify.com/r/5354089055656094

@Nathan-Mulugeta

Payouts due:

Issue Reporter: $250 @Nathan-Mulugeta
Contributor: $2000 + 50% urgency bonus = $3000 @cubuspl42
Contributor+: $2000 + 50% urgency bonus = $3000 @rushatgabhane via manual request

Eligible for 50% #urgency bonus? Yes

Upwork job is here.

All done now, thanks everyone!

@rushatgabhane

Reviewed the details for @rushatgabhane. $3,000 payment approved via NewDot based on the BZ summary above.

Navigation Menu

Repository navigation

[HOLD for payment 2023-08-21] [$2000] Hitting enter key on keyboard does not select a pronoun #21472

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

80 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-08-21] [$2000] Hitting enter key on keyboard does not select a pronoun #21472

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 23, 2023

melvin-bot commented on Jun 23, 2023

Bug0 Triage Checklist (Main S/O)

jakub-trzebiatowski commented on Jun 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

conorpendergrast commented on Jun 26, 2023

melvin-bot commented on Jun 26, 2023

melvin-bot commented on Jun 26, 2023

80 remaining items

melvin-bot commented on Aug 14, 2023

melvin-bot commented on Aug 14, 2023

melvin-bot commented on Aug 14, 2023

rushatgabhane commented on Aug 14, 2023

rushatgabhane commented on Aug 14, 2023

conorpendergrast commented on Aug 21, 2023

conorpendergrast commented on Aug 21, 2023

JmillsExpensify commented on Aug 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions