[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-03] [$1000] Polish admins-only policy room feature

[amyevans]

Background

We recently added a configurable setting to all default and user-created policy rooms, available to admins only, that allows admins to define who can post in that room: All members or Admins only. This enables admins to "control the conversation" in rooms that have large membership, or for whatever other reason should be lower-noise.

While the bulk of the work is complete, there's some remaining polish to be done on the FE.

Tasks

• Add the "Who can post" setting to the "New Room" form

• The default form value should be all
• Send the writeCapability value when calling the AddWorkspaceRoom endpoint
• Ensure the value is included in the optimisticData (to support offline creation)
• Note: BE PRs supporting the writeCapability value in the AddWorkspaceRoom endpoint aren't live yet, but don't need to block work here

• Filter out admin-only rooms for members in the "Share somewhere" selector of the "Assign task" action (accessible via the FAB menu) - so that members cannot share a task to the room
• Reduce the padding between the last message and the bottom of the page when the composer isn't present (e.g. for the "member" view in an admin-only room)
• Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for admin-only rooms

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012ddadecb1f0a54b9
• Upwork Job ID: 1675048364496478208
• Last Price Increase: 2023-07-01

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[amyevans]

Internal issue for reference: https://github.com/Expensify/Expensify/issues/282865

I shared in Slack to see if a Callstack team member has capacity for this.

[jliexpensify]

LMK if you need any Upworks stuff sorted!

[rezkiy37]

Hi, I'm Michael (Mykhailo) from Callstack and I would like to work in this issue.

[rezkiy37]

@amyevans Hi!
Is it possible to add my Expensify accounts to the white list of Create Policy Room and tasks?

[amyevans]

Done

[rezkiy37]

@amyevans I have a question about the last task.
Do you mean to replace entirely?

• Before: Collaboration among ${workspaceName} admins starts here! 🎉 Use ${roomName} to chat about topics such as workspace configurations and more.

• After: Use ${roomName} to hear about important announcements related to ${workspaceName}.

[amyevans]

Collaboration among ${workspaceName} admins starts here! 🎉 Use ${roomName} to chat about topics such as workspace configurations and more.

This is the copy for the #admins room, and the #admins room is something different - it is one of 2 rooms created by default when you create a new workspace aka policy (#announce being the other default room). The purpose of the #admins room is for collaboration between admins. Users who are members of the policy (but not admins of the policy) are not in the #admins room.

Then we have this feature we're working on here, which is any room that is restricted to only admins posting (but plenty of non-admins are in the room). Check out the screen recordings/code in #19094 for more context. So we'll want to insert a new condition here-ish:

App/src/libs/ReportUtils.js

Line 571 in 5c6b751

} else if (isDomainRoom(report)) {

that checks if it's a room where only admins can post and then spits out Use ${roomName} to hear about important announcements related to ${workspaceName}.

Does that make sense?