[HOLD for payment 2023-07-21] [$1000] Long Pressing on reply opens the context menu for the ReportPreview action.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a DM with any user.
2. Send a Money request.
3. Long Press on the reply 1 on the preview of money request in the DM.
4. Observe the behaviour.

Expected Result:

It should not open the context menu on the IOU Preview like other platforms.

Actual Result:

It opens the context menu on Android chrome but other platforms does not open it.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-15.at.6.37.45.PM.mov

az_recorder_20230621_223902.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686834876030139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0164ddcb49f1eae0da
• Upwork Job ID: 1672146114797383680
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long Pressing on reply opens the context menu for the ReportPreview action.

What is the root cause of that problem?

Problem came from here:

App/src/pages/home/report/ReportActionItemThread.js

Lines 42 to 48 in e6c4b4e

	<PressableWithoutFeedback
	onPress={() => {
	Report.navigateToAndOpenChildReport(props.childReportID);
	}}
	accessibilityRole="button"
	accessibilityLabel={`${props.numberOfReplies} ${replyText}`}
	>

We didn't implement the onLongPress for PressableWithoutFeedback yet, so when we long pressed, it will open the ContextMenu.

What changes do you think we should make in order to solve the problem?

We should add the onLongPress={() => {}} here.

            <PressableWithoutFeedback
                onLongPress={() => {}}
                onPress={() => {
                    Report.navigateToAndOpenChildReport(props.childReportID);
                }}
                accessibilityRole="button"
                accessibilityLabel={`${props.numberOfReplies} ${replyText}`}
            >

What alternative solutions did you explore? (Optional)

Add onLongPress default props our GenericPressable.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0164ddcb49f1eae0da

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[ShogunFire]

I don't think this is a bug, it acts this way for any comment and long pressing on mobile is the equivalent of right clicking on other platforms which also open the context menu. @eVoloshchak am I missing something ?