[HOLD for payment 2023-07-10] [$1000] Different sections opened clicking on empty space in thread header

@Natnael-Guchima

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open an existing chat
Send message
Reply with a thread
Open the threaded chat
Click on 'From user name' link
Verify that user is navigated to the main chat
Open the threaded chat again
Click on the blank space next to the thread header name
Obsereve that the details sidebar is opened
Close the sidebar & click on a blank space next to 'From user name' link

Expected Result:

Details sidebar should be opened counting all the blank parts of the header as part of the header to avoid confusion. And clicking only the link should navigate user to main chat

Actual Result:

User is navigate back to main chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-06-15.10.56.35.mp4

Recording.1046.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686816426119499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e25a8a95ef65423b
Upwork Job ID: 1672116435942555648
Last Price Increase: 2023-06-23

@sophiepintoraetz

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Different sections open when user clicks on empty space in thread header. When space next to parent chat is clicked, it opens the parent chat and not chat details.

What is the root cause of that problem?

Subtitle expands to full width here because of flex: 1 which is set on its parent.

App/src/pages/home/HeaderView.js

Lines 180 to 198 in 0b7455f

    
           <View style={[styles.flex1, styles.flexColumn]}> 
        
               <DisplayNames 
        
                   fullTitle={title} 
        
                   displayNamesWithTooltips={displayNamesWithTooltips} 
        
                   tooltipEnabled 
        
                   numberOfLines={1} 
        
                   textStyles={[styles.headerText, styles.pre]} 
        
                   shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isThread || isTaskReport} 
        
               /> 
        
               {(isChatRoom || isPolicyExpenseChat || isThread) && !_.isEmpty(subtitle) && ( 
        
                   <> 
        
                       {isThread ? ( 
        
                           <PressableWithoutFeedback 
        
                               onPress={() => { 
        
                                   Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID)); 
        
                               }} 
        
                               accessibilityLabel={subtitle} 
        
                               accessibilityRole="link" 
        
                           >

What changes do you think we should make in order to solve the problem?

If we just remove styles.flex1 or only flex-grow: 1 then parent chat won't be truncated on phone.
If we add styles.alignSelfStart on View or PressableWithoutFeedback then also parent chat won't be truncated on phone.

See video

Screen.Recording.2023-06-23.at.3.44.46.PM.mov

We need to add new property in sizing.js for max-width either set to max-content or fit-content and then pass this style in PressableWithoutFeedback like -
Add new style prop to -

<PressableWithoutFeedback
    ...
    style={[styles.mwFitContent]}

We can use fit-content since it calculates the value based on available space like -

fit-content uses max-content, unless available < max-content, then it uses available. Unless available < min-content, then it uses min-content.

What alternative solutions did you explore? (Optional)

NA

Result -

Screen.Recording.2023-06-23.at.3.46.01.PM.mov

Proposal

Please re-state the problem that we are trying to solve in this issue.

Different sections opened clicking on empty space in thread header

What is the root cause of that problem?

By default the align-items is stretch which will makes the subtitle to takes full available width and that is the reason for the issue.

What changes do you think we should make in order to solve the problem?

Pass style prop here for PressableWithoutFeedback with style={styles.alignSelfStart} which will restrict the stretching and takes only required width. To avoid the overflow when the text is longer we need to also provide styles.mw100.

App/src/pages/home/HeaderView.js

Lines 192 to 198 in 0b7455f

    
           <PressableWithoutFeedback 
        
               onPress={() => { 
        
                   Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID)); 
        
               }} 
        
               accessibilityLabel={subtitle} 
        
               accessibilityRole="link" 
        
           >

Will look into this tomorrow - overrun with some other chores.

@chiragsalian

I can replicate - I think this may have come from PR #20484 (cc @chiragsalian)

Job added to Upwork: https://www.upwork.com/jobs/~01e25a8a95ef65423b

@sophiepintoraetz

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

@mananjadhav

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@mananjadhav

@mananjadhav - if you can complete the checklist, that would be great!

@sophiepintoraetz

@sophiepintoraetz thanks for the bump, I'll finish this over the weekend.

@MariaHCD

The offending PR is #20484. I've posted the comment in the PR. I think the issue occurred because we copy pasted the Text content, which didn't have the click behavior earlier.

I don't see any action needed here. I also don't think we need a regression test here as it's not something that would change often. @MariaHCD wdyt?

@mananjadhav

Thanks @mananjadhav - I agree if it was lack of attention to detail, there's no update needed here. Thanks for posting the FYI - contracts are out!

@sophiepintoraetz

@sophiepintoraetz payment is yet to be received for the contract. Can you plz check once? Thanks!

@Pujan92

@Pujan92 - some patience would be good here - payments are manually processed so I have to wait until you accept the offer in order to pay you - and there are other pieces of work I am doing!

I actually accepted the offer earlier. Usually, GH issue gets closed after the payment so thought of putting a message here. Sorry but didn't mean to rush here for payment.

@sophiepintoraetz

@sophiepintoraetz I've requested the payout via NewDot.

Thanks for the patience here @Pujan92. Have you accepted the offer and paid out now?

Yep, he should have been paid! And yes - I realise that change has just gone live, Anu should be taking care of that.

Yes thats right. Thanks for your help here.

Yes, I got paid. Thanks!

Paid Manan after confirming here.

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-10] [$1000] Different sections opened clicking on empty space in thread header #21215

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<View style={[styles.flex1, styles.flexColumn]}>
	<DisplayNames
	fullTitle={title}
	displayNamesWithTooltips={displayNamesWithTooltips}
	tooltipEnabled
	numberOfLines={1}
	textStyles={[styles.headerText, styles.pre]}
	shouldUseFullTitle={isChatRoom \|\| isPolicyExpenseChat \|\| isThread \|\| isTaskReport}
	/>
	{(isChatRoom \|\| isPolicyExpenseChat \|\| isThread) && !_.isEmpty(subtitle) && (
	<>
	{isThread ? (
	<PressableWithoutFeedback
	onPress={() => {
	Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID));
	}}
	accessibilityLabel={subtitle}
	accessibilityRole="link"
	>

[HOLD for payment 2023-07-10] [$1000] Different sections opened clicking on empty space in thread header #21215

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 21, 2023

Bug0 Triage Checklist (Main S/O)

Nikhil-Vats commented on Jun 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Pujan92 commented on Jun 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

sophiepintoraetz commented on Jun 22, 2023

sophiepintoraetz commented on Jun 23, 2023

melvin-bot commented on Jun 23, 2023

melvin-bot commented on Jun 23, 2023

melvin-bot commented on Jun 23, 2023

22 remaining items

sophiepintoraetz commented on Jul 5, 2023

mananjadhav commented on Jul 6, 2023

mananjadhav commented on Jul 10, 2023

sophiepintoraetz commented on Jul 11, 2023

Pujan92 commented on Jul 11, 2023

sophiepintoraetz commented on Jul 11, 2023

Pujan92 commented on Jul 11, 2023

mananjadhav commented on Jul 12, 2023

sophiepintoraetz commented on Jul 12, 2023

mananjadhav commented on Jul 12, 2023

Pujan92 commented on Jul 12, 2023

anmurali commented on Jul 13, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions