[HOLD for payment 2023-07-26] [$1000] Web - The tooltip end is broken for users with long names on details page of group chat

@priya-zha

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome and login with User A
Create a group with multiple users
Click on details page
Login with any one user on another web chrome that you have create a group with
Change the display name of the user and replace it with a long name (max character)
Go to User A and hover over the username of the user on the details page and notice that the pointer of the tooltip is broken (not centered)

Expected Result:

The pointer of the tooltip should be centered

Actual Result:

The pointer of the tooltip is off-center for users with long names on details page of group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.29.2

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-13_11.24.23.1.mp4

Recording.2662.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686635011685439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01813ef7a0589a7c4b
Upwork Job ID: 1676961079120977920
Last Price Increase: 2023-07-06

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@alitoshmatov

Looks like @alitoshmatov has a proposal in the above-linked GH that should fix this as well.

I'm going to downgrade this to Weekly while we wait on the other issue to get resolved.

@johncschuster

@johncschuster Looks like the other issue is closed, I think you should proceed with this one. Just in case, I am going post my proposal here as well

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Tooltip pointer is not pointing to the center of the text

What is the root cause of that problem?

We are not passing shiftHorizontal prop down to tooltip in UserDetailsTooltip which is responsible for preventing this kind of issue, where child element is not visible and its center is outside of parent element. We are passing shiftHorizontal to UserDetailsTooltip

App/src/components/DisplayNames/index.js

Line 100 in ddc19e0

shiftHorizontal={() => this.getTooltipShiftX(index)}

What changes do you think we should make in order to solve the problem?

We should pass props.shiftHorizontal down to Tooltip component here:

App/src/components/UserDetailsTooltip/index.js

Line 42 in e6c2704

    
           return <Tooltip renderTooltipContent={renderTooltipContent}>{props.children}</Tooltip>;

  shiftHorizontal={props.shiftHorizontal}

Result:

What alternative solutions did you explore? (Optional)

@johncschuster

@johncschuster I am still using upwork

Ah, thanks for calling that out! I'll get payment issued via Upwork for you then.

@aimane-chnaif

I have issued payment to @aimane-chnaif via Upwork.

@priya-zha, I've sent the invite to you via Upwork. Can you accept that so I can issue payment?

Thanks.. Accepted.

@priya-zha

Thank you! I've issued payment to @priya-zha.

@cead22

@cead22, @johncschuster, @alitoshmatov, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

@cead22

@cead22, @johncschuster, @alitoshmatov, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

On hold for payment and not overdue

Uhh... I don't think that's right. I issued payment, and it looks like I totally forgot to close the issue. 🤦

Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2023-07-26] [$1000] Web - The tooltip end is broken for users with long names on details page of group chat #21100

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

80 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-07-26] [$1000] Web - The tooltip end is broken for users with long names on details page of group chat #21100

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 20, 2023

melvin-bot commented on Jun 20, 2023

Bug0 Triage Checklist (Main S/O)

johncschuster commented on Jun 22, 2023

johncschuster commented on Jun 26, 2023

alitoshmatov commented on Jun 30, 2023

alitoshmatov commented on Jun 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

80 remaining items

aimane-chnaif commented on Aug 13, 2023

johncschuster commented on Aug 14, 2023

johncschuster commented on Aug 14, 2023

priya-zha commented on Aug 15, 2023

johncschuster commented on Aug 15, 2023

melvin-bot commented on Aug 21, 2023

melvin-bot commented on Aug 21, 2023

cead22 commented on Aug 22, 2023

johncschuster commented on Aug 25, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions