Skip to content

[$1000] [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits #21044

Closed
Closed
[$1000] [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits#21044
Assignees
johncschusterluacmartinsroryabrahamaldo-expensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@kbecciv
kbecciv
opened on Jun 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to staging dot on web chrome
  2. Go to any old group chat where you splitted the bill (Important- split bill report)
  3. Click on it and notice that details page is empty
  4. But if you split the bill now in the same group and then click on the split bill report, you'll be able to see the details without any problem. Thus the problem occurs for old split bills and not the new ones.

Expected Result:

Details page should be not shown empty for old group chat splits

Actual Result:

Details page is shown empty for old group chat splits

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

green-2023-06-19_15.13.45.mp4
Recording.3156.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687167180014059

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01034e11a536cbe311
  • Upwork Job ID: 1673377762610040832
  • Last Price Increase: 2023-06-26

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 19, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Jun 19, 2023

  3. OSBotify commented on Jun 19, 2023

    @OSBotify
    OSBotify
    on Jun 19, 2023
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    roryabraham
    on Jun 19, 2023

  5. melvin-bot commented on Jun 19, 2023

    @melvin-bot
    melvin-botBot
    on Jun 19, 2023

    Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. roryabraham commented on Jun 19, 2023

    @roryabraham
    roryabraham
    on Jun 19, 2023
    Contributor

    The problem here is that we changed the shape of reportActions data to go from originalMessage.participants -> originalMessage.participantAccountIDs and didn't migrate old reportActions...

  7. aldo-expensify commented on Jun 20, 2023

    @aldo-expensify
    aldo-expensify
    on Jun 20, 2023
    Contributor

    I chatted with Alex. B about this and it seems like we didn't migrate the database data. I'll try to prepare a CQ query to migrate.

  8. aldo-expensify
    self-assigned this
    on Jun 20, 2023
  9. luacmartins
    self-assigned this
    on Jun 20, 2023

  10. luacmartins commented on Jun 20, 2023

    @luacmartins
    luacmartins
    on Jun 20, 2023
    Contributor

    Removing the blocker label as per this comment

  11. luacmartins
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Jun 20, 2023

  12. luacmartins commented on Jun 21, 2023

    @luacmartins
    luacmartins
    on Jun 21, 2023
    Contributor

    This was fixed, CPed and deployed to prod. No payments are due. Closing.

  13. 24 remaining items

  14. melvin-bot commented on Jun 26, 2023

    @melvin-bot
    melvin-botBot
    on Jun 26, 2023

    Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

  15. melvin-bot
    assigned
    mollfpr
    on Jun 26, 2023

  16. melvin-bot commented on Jun 26, 2023

    @melvin-bot
    melvin-botBot
    on Jun 26, 2023

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  17. johncschuster
    unassigned
    mollfpr
    on Jun 26, 2023

  18. johncschuster commented on Jun 26, 2023

    @johncschuster
    johncschuster
    on Jun 26, 2023
    Contributor

    Sorry for the ping, @mollfpr. I applied the External label just to create the Upwork job to pay the reporting bonus.

  19. johncschuster commented on Jun 26, 2023

    @johncschuster
    johncschuster
    on Jun 26, 2023
    Contributor

    @priya-zha, can you apply for the job above?

  20. priya-zha commented on Jun 26, 2023

    @priya-zha
    priya-zha
    on Jun 26, 2023

    @johncschuster proposal submitted. thanks

  21. melvin-bot commented on Jun 26, 2023

    @melvin-bot
    melvin-botBot
    on Jun 26, 2023

    📣 @mentamarindos! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  22. lealobanov commented on Jun 26, 2023

    @lealobanov
    lealobanov
    on Jun 26, 2023

    Contributor details
    Your Expensify account email: lea.lobanov@icloud.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0187e5647dc5b9d97e

  23. melvin-bot commented on Jun 26, 2023

    @melvin-bot
    melvin-botBot
    on Jun 26, 2023

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  24. melvin-bot commented on Jun 26, 2023

    @melvin-bot
    melvin-botBot
    on Jun 26, 2023

    📣 @phoenixdevguru! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  25. melvin-bot commented on Jun 26, 2023

    @melvin-bot
    melvin-botBot
    on Jun 26, 2023

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  26. johncschuster commented on Jun 27, 2023

    @johncschuster
    johncschuster
    on Jun 27, 2023
    Contributor

    Hi @phoenixdevguru, this issue has already been resolved. We're just working on issuing payment to the bug reporter.

  27. johncschuster commented on Jun 28, 2023

    @johncschuster
    johncschuster
    on Jun 28, 2023
    Contributor

    Payment has been issued! I think we're good to close this out.

  28. johncschuster
    closed this as completedon Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions