[HOLD for payment 2023-07-26] [$1000] Web - User is not navigated to the concierge chat after login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log out of NewDot
2. Go to https://staging.new.expensify.com/concierge
3. Verify that you are taken to the login screen
4. Log in to NewDot
5. Verify you're navigated to the concierge chat after login

Expected Result:

User should be navigated to the concierge chat after login

Actual Result:

After login, user is navigated to the last chat of his/her last session

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6094809_Bug_1_-_Staging_-_2023-06-15_18-10-46.mp4

2023-06-15.23-34-01.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0195b3719c902bfe8a
• Upwork Job ID: 1669733106684628992
• Last Price Increase: 2023-07-07

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

This seems to be a real blocker.

[mountiny]

Asked @WoLewicki to have a look

[mountiny]

And @koko57 too 😄 lets get this fixed

[WoLewicki]

The problem comes from how ReportScreenWrapper works right now. It sets the reportID to the last visited id. The solution would be to set the last visited report to Concierge when user signs in. I'm looking for the best place to add it. Do you have an idea where should it be?

[koko57]

@mountiny @WoLewicki My finding so far:
I've tested the app on a revision before this PR was merged and after merging these changes.

First I've noticed that we don't have a proper id for the concierge chat when calling navigateToConciergeChat here.

After comparing with the changes before the PR it looks like the Onyx is populated with data before the navigateToConciergeChat - looks like the SidebarUtils.isSidebarLoadedReady() is resolved quicker than Navigation.isReportScreenReady()

here are the logs:

before changes

after changes

So the flow basically looks like this:

• after logging in the Concierge page mounts and the navigateToConciergeChat() is called here
• we don't have the id for the concierge chat -> we're navigated to the Report page here
• as the ReportScreen mounts Navigation.isReportScreenReady() (in the old revision) and SidebarUtils.isSidebarLoadedReady() (in the revision after the PR) are resolved - but it looks like the SidebarUtils.isSidebarLoadedReady() is resolved earlier
• navigateToConciergeChat() is called here and as we already have the concierge report Id in the case with Navigation.isReportScreenReady() we're navigated to the Concierge chat, while in the SidebarUtils.isSidebarLoadedReady() we're not

A lot happens here and I hope I explained it as clear as possible 😅 , but if you still have any questions just let me know 🙂

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[AndrewGable]

Demoting to bug per: https://expensify.slack.com/archives/C01GTK53T8Q/p1686927085343139?thread_ts=1686924049.839489&cid=C01GTK53T8Q