[HOLD for payment 2023-06-23] Standardize our functional component declaration style via a lint rule

[roryabraham]

Problem

We currently have functional components declared as arrow functions, and others declared as functions. We have standardized this in our code standards, but don't have anything in place to enforce this code style.

Solution

Add a lint rule for it 🙂

[roryabraham]

Reopening this until I:

• Bump the package version in eslint-config-expensify
• Republish the eslint-config-expensify package
• Bump the package version in E/App and run npm run lint -- --fix

[roryabraham]

Big PR to standardize our functional component declaration style is ready for review: #20724

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Add lint rule for functional component declaration style #20724

If no regressions arise, payment will be issued on 2023-06-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty