[HOLD for payment 2023-07-17] [$1000] OS Safari - All 6 digits visible in first digit slot when using OTP autofill

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to new.expensify.com in Safari on iOS.
2. Enter your phone number.
3. Click on the code that appears in the keyboard autofill.
4. Notice that in the first digit placeholder, all 6 digits are visible but in other slots the correct digits are visible.

Expected Result:

Each digit should be visible in its own slot.

Actual Result:

All digits are visible in the first slot, in the other slots (2nd to 6th), correct digits are visible.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.24-5
Reproducible in staging?: needs reproduction ( I don't have iphone with sim)
Reproducible in production?: needs reproduction ( I don't have iphone with sim)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

magic_code_bug.MP4

Expensify/Expensify Issue URL:
Issue reported by: @Nikhil-Vats)
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686154610357189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ac63cca1c7fc022
• Upwork Job ID: 1669104099919405056
• Last Price Increase: 2023-06-21

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[KALLL]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On OTP autofill all 6 digits are visible on the first field

What is the root cause of that problem?

The maxLength for each individual OTP field has been set to be Length of the OTP = 6

App/src/components/MagicCodeInput.js

Lines 315 to 321 in 93957f0

	<TextInput
	ref={(ref) => (inputRefs.current[index] = ref)}
	autoFocus={index === 0 && props.autoFocus}
	inputMode="numeric"
	textContentType="oneTimeCode"
	name={props.name}
	maxLength={props.maxLength}

App/src/components/MagicCodeInput.js

Line 68 in 93957f0

maxLength: CONST.MAGIC_CODE_LENGTH,

What changes do you think we should make in order to solve the problem?

We don't have to change the defaultProps maxLength value as it is being used for other purposes like decomposeString()
but we can change the maxLength of the TextInput :
Inside the TextInput doing maxLength={1} like

<TextInput
                                ref={(ref) => (inputRefs.current[index] = ref)}
                                autoFocus={index === 0 && props.autoFocus}
                                inputMode="numeric"
                                textContentType="oneTimeCode"
                                name={props.name}
                                maxLength={1}

will solve the problem.

What alternative solutions did you explore? (Optional)

Another possible solution is to use the onChangeText prop instead of the value prop to handle the autofill logic

[stephanieelliott]

I was able to repro this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013ac63cca1c7fc022

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)