Repository navigation
[$1000] [HOLD for payment 2023-07-20] [Manual Requests] Make the Datepicker component more reusable #20630
Description
Problem
The NewDatePicker component has went trhough couple of iterations and its time to refactor it and mainly make it easier to reuse in other flows and pages of the app. Some context in this thread
Why is it important?
We are adding more flows which require a date picker component, however, the current implementation is hard to just take and plug into some other form with different routes so it just works. For example in this PR we need to make it easy to implement a date picker to a request details page
Solution
Explore how we can simplify this component so we keep the current functionality and design ideally while improving the DX.
cc @Beamanator @burczu @WoLewicki @adamgrzybowski @s77rt @luacmartins
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~018d352aca1b0ce802
- Upwork Job ID: 1683554983031660544
- Last Price Increase: 2023-07-24
Activity
melvin-bot commentedon Jun 12, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mountiny commentedon Jun 12, 2023
Asking Bartek if he wants to tackle this one tomorrow as they originally worked on this issue
burczu commentedon Jun 14, 2023
Hi I'm Bartek from Callstack - expert contributor group - I would like to work on this issue.
WoLewicki commentedon Jun 14, 2023
I would gladly review the part with subscribing to navigation and the information flow in those components 😅
melvin-bot commentedon Jun 14, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
mountiny commentedon Jun 14, 2023
Nice, I will assign you too, its important issue to get done right
mountiny commentedon Jun 14, 2023
@burczu previously, we wanted the Year page to be its own route with the psuh-to-page design which is quite complicated.
Could we potentially make this page "internal" to the datepicker route so it looks same as a new page in the stack. This might introduce issues with the navigation tho to keep the browser back and in-app Up actions consistent.
Maybe we could also disallow deeplinking to the year page which could help with some edge cases so that when you try to access the year page by using deeplink it would redirect to the date picker first.
Not sure whats the best way but lets brainstorm our options
51 remaining items
[-][HOLD for payment 2023-07-20] [Manual Requests] Make the Datepicker component more reusable[/-][+][$1000] [HOLD for payment 2023-07-20] [Manual Requests] Make the Datepicker component more reusable[/+]melvin-bot commentedon Jul 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~018d352aca1b0ce802
melvin-bot commentedon Jul 24, 2023
Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.
kevinksullivan commentedon Jul 24, 2023
Just labeling to get the upwork job set up.
melvin-bot commentedon Jul 24, 2023
Current assignees @ArekChr and @fedirjh are eligible for the External assigner, not assigning anyone new.
kevinksullivan commentedon Jul 24, 2023
Offer sent @fedirjh ^^ . Let me know when you accept!
fedirjh commentedon Jul 24, 2023
@kevinksullivan Thank you! Accepted
JmillsExpensify commentedon Jul 24, 2023
Woo! Awesome work on this one. Excited to have it in the wild.
mountiny commentedon Jul 26, 2023
@kevinksullivan All done here, can we close this?
kevinksullivan commentedon Jul 28, 2023
All set / paid