Repository navigation
[HOLD for payment 2023-07-17] Selection List Refactor: Radio Button List #20352
Description
Activity
- addedImprovementItem broken or needs improvement.Item broken or needs improvement.WeeklyKSv2KSv2
on Jun 7, 2023 Update: still on Step 1
Step 1: Create a new, clean component for the Radio Button List, keeping the old one untouched
Thanks for the update!
Reacted by Thiago BrezinskiLeft an update in the umbrella issue:
Working on #20352. Got a clean component working with all previous features for one use-case (Timezone selection). Now, for the other use-cases it should be simpler as the base is done, and I might just need to add a few extra props for customisation. Then, I'll create a few Storybook stories to leave it well documented.
Finishing clean-up. Will send a PR tomorrow
PR ready to review here: #21048
Weekly update: PR waiting for review
Weekly update: PR is being reviewed, appears to be close to approval
- addedWeeklyKSv2KSv2Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionand removedWeeklyKSv2KSv2
on Jul 10, 2023 - changed the title
[-]Selection List Refactor: Radio Button List[/-][+][HOLD for payment 2023-07-17] Selection List Refactor: Radio Button List[/+]on Jul 10, 2023 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
- Merged PR within 3 business days of assignment - 50% bonus
- Merged PR more than 9 business days after assignment - 50% penalty
@cristipaval, @thiagobrez, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!
Santhosh-Sellavel commented
on Jul 20, 2023 CollaboratorMore actions@twisterdotcom Actually payment should have been got here, we mixed up on the parent issue and got it there.
We are good to close this one out, thanks!
Oh weird, yes this is kind of a dupe. Okay, we can close this one then.
This issue keeps track of Phase 1 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:
Thoroughly discussed in the parent issue: #11795 (comment)