Skip to content

[HOLD for payment 2023-07-17] Selection List Refactor: Radio Button List #20352

Description

@thiagobrez

This issue keeps track of Phase 1 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:

  • Phase 1: Radio Button List (this phase)
  • Phase 2: Checkbox List
  • Phase 3: Simple Selection List

Thoroughly discussed in the parent issue: #11795 (comment)

Activity

  1. self-assigned this
    on Jun 7, 2023
  2. thiagobrez commented on Jun 9, 2023

    @thiagobrez
    ContributorAuthor

    Update: still on Step 1

    Step 1: Create a new, clean component for the Radio Button List, keeping the old one untouched

  3. cristipaval commented on Jun 9, 2023

    @cristipaval
    Contributor

    Thanks for the update!

  4. thiagobrez commented on Jun 16, 2023

    @thiagobrez
    ContributorAuthor

    Left an update in the umbrella issue:

    Working on #20352. Got a clean component working with all previous features for one use-case (Timezone selection). Now, for the other use-cases it should be simpler as the base is done, and I might just need to add a few extra props for customisation. Then, I'll create a few Storybook stories to leave it well documented.

  5. thiagobrez commented on Jun 19, 2023

    @thiagobrez
    ContributorAuthor

    Finishing clean-up. Will send a PR tomorrow

  6. thiagobrez commented on Jun 20, 2023

    @thiagobrez
    ContributorAuthor

    PR ready to review here: #21048

  7. thiagobrez commented on Jun 23, 2023

    @thiagobrez
    ContributorAuthor

    Weekly update: PR waiting for review

  8. thiagobrez commented on Jun 30, 2023

    @thiagobrez
    ContributorAuthor

    Weekly update: PR is being reviewed, appears to be close to approval

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 10, 2023
  10. changed the title [-]Selection List Refactor: Radio Button List[/-] [+][HOLD for payment 2023-07-17] Selection List Refactor: Radio Button List[/+] on Jul 10, 2023
  11. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-17. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on Jul 20, 2023

    @melvin-bot

    @cristipaval, @thiagobrez, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. Santhosh-Sellavel commented on Jul 20, 2023

    @Santhosh-Sellavel
    Collaborator

    @twisterdotcom Actually payment should have been got here, we mixed up on the parent issue and got it there.

    #11795 (comment)

    We are good to close this one out, thanks!

  15. twisterdotcom commented on Jul 21, 2023

    @twisterdotcom
    Contributor

    Oh weird, yes this is kind of a dupe. Okay, we can close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions