[$1000] mWeb - Copy to clipboard option not present on the link type: Schedule a setup call

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Menu > Workspaces > tap into a Workspace
2. Tap on the (?) help icon in top-right
3. Press and hold on the "Scheduled a set up call"

Expected Result:

Copy to clipboard option should be present for all links

Actual Result:

Copy to clipboard link is not present for Schedule a setup call

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: yas

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenrecorder-2023-05-22-23-24-48-774.mp4

Screen_Recording_20230606_174510_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @chiragxarora

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684778570184059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014701441d97e4e225
• Upwork Job ID: 1666454151545909248
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy to clipboard option not present on the link type: Schedule a setup call

What is the root cause of that problem?

Root cause of the problem lies in the GetAssistancePage where for the Calendar link, we are not passing the link prop to the Calendar link component which we are pushing in menu items list.

App/src/pages/GetAssistancePage.js

Lines 66 to 76 in 758ef37

	const guideCalendarLink = lodashGet(props.account, 'guideCalendarLink');
	if (guideCalendarLink) {
	menuItems.splice(1, 0, {
	title: props.translate('getAssistancePage.scheduleSetupCall'),
	onPress: () => Linking.openURL(guideCalendarLink),
	icon: Expensicons.Phone,
	shouldShowRightIcon: true,
	iconRight: Expensicons.NewWindow,
	wrapperStyle: [styles.cardMenuItem],
	});
	}

This missing prop prevents the desired behavior on right click/ long press which opens a copy to clipboard popover in other links present in the app.

What changes do you think we should make in order to solve the problem?

We need to pass the additional link prop to the calendar link item in menu items before we render it in the component.
By doing this, whenever user is eligible for calls with their guide, guideCalendarLink will contain a link which will set the if condition true.
And now we need to pass the link prop with the value as guideCalendarLink and we are done.

const guideCalendarLink = lodashGet(props.account, 'guideCalendarLink');
    if (guideCalendarLink) {
        menuItems.splice(1, 0, {
            title: props.translate('getAssistancePage.scheduleSetupCall'),
            onPress: () => Linking.openURL(guideCalendarLink),
            icon: Expensicons.Phone,
            shouldShowRightIcon: true,
            iconRight: Expensicons.NewWindow,
            wrapperStyle: [styles.cardMenuItem],
            link: guideCalendarLink,
        });
    }

Results

### What alternative solutions did you explore? (Optional) None

[chiragxarora]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy to clipboard option not present on the link type: Schedule a setup call

What is the root cause of that problem?

Root cause of the problem lies in the GetAssistancePage where for the Calendar link, we are not passing the link prop to the Calendar link component which we are pushing in menu items list.

App/src/pages/GetAssistancePage.js

Lines 66 to 76 in 758ef37

	const guideCalendarLink = lodashGet(props.account, 'guideCalendarLink');
	if (guideCalendarLink) {
	menuItems.splice(1, 0, {
	title: props.translate('getAssistancePage.scheduleSetupCall'),
	onPress: () => Linking.openURL(guideCalendarLink),
	icon: Expensicons.Phone,
	shouldShowRightIcon: true,
	iconRight: Expensicons.NewWindow,
	wrapperStyle: [styles.cardMenuItem],
	});
	}

This missing prop prevents the desired behavior on right click/ long press which opens a copy to clipboard popover in other links present in the app.

What changes do you think we should make in order to solve the problem?

We need to pass the additional link prop to the calendar link item in menu items before we render it in the component.
By doing this, whenever user is eligible for calls with their guide, guideCalendarLink will contain a link which will set the if condition true.
And now we need to pass the link prop with the value as guideCalendarLink and we are done.

const guideCalendarLink = lodashGet(props.account, 'guideCalendarLink');
    if (guideCalendarLink) {
        menuItems.splice(1, 0, {
            title: props.translate('getAssistancePage.scheduleSetupCall'),
            onPress: () => Linking.openURL(guideCalendarLink),
            icon: Expensicons.Phone,
            shouldShowRightIcon: true,
            iconRight: Expensicons.NewWindow,
            wrapperStyle: [styles.cardMenuItem],
            link: guideCalendarLink,
        });
    }

Results

bandicam.2023-06-05.20-50-02-623.mp4

### What alternative solutions did you explore? (Optional) None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014701441d97e4e225

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)