Skip to content

[HOLD for payment 2023-06-21] [$1000] Update user tooltips to include avatar, display name, and handle #20086

Closed

Description

@puneetlath

Today our user tooltips look like this:

image

We want to update them to look like this:

image

Things to note:

  1. The three elements on the tooltip are avatar, display name, handle
  2. Handle is a new field that is being added to the personalDetails object in this back-end PR (Note: That back-end PR got reverted 😅 )
  3. Display name and handle are not always present, so we should gracefully handle showing whichever of the three pieces of information we have available.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01630563c7656399b7
  • Upwork Job ID: 1664697769214058496
  • Last Price Increase: 2023-06-02

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on Jun 2, 2023
  2. changed the title [-]Update user tooltips to include avatar, display name, and handle[/-] [+][$1000] Update user tooltips to include avatar, display name, and handle[/+] on Jun 2, 2023
  3. melvin-bot commented on Jun 2, 2023

    @melvin-bot
  4. melvin-bot commented on Jun 2, 2023

    @melvin-bot
  5. melvin-bot commented on Jun 2, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. melvin-bot commented on Jun 2, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  7. 37 remaining items

  8. changed the title [-][$1000] Update user tooltips to include avatar, display name, and handle[/-] [+][HOLD for payment 2023-06-21] [$1000] Update user tooltips to include avatar, display name, and handle[/+] on Jun 14, 2023
  9. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Jun 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter n/a
    • Contributor that fixed the issue @cloudpresser
    • Contributor+ that helped on the issue and/or PR @fedirjh

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. grgia commented on Jun 15, 2023

    @grgia
    Contributor

    Commented on the PR as well, but I think we need to handle workspace avatars case: https://expensify.slack.com/archives/C049HHMV9SM/p1686821040533159

  12. puneetlath commented on Jun 23, 2023

    @puneetlath
    ContributorAuthor

    @cloudpresser @fedirjh sorry for the delay. Sent you both hiring offers.

  13. fedirjh commented on Jun 23, 2023

    @fedirjh
    Contributor

    @puneetlath Thanks, accepted.

  14. puneetlath commented on Jun 26, 2023

    @puneetlath
    ContributorAuthor

    @cloudpresser friendly bump on accepting the Upwork offer. That way I can get you paid and we can close out this issue. Thanks!

  15. cloudpresser commented on Jun 26, 2023

    @cloudpresser
    Contributor

    @puneetlath Accepted, thanks

  16. puneetlath commented on Jun 27, 2023

    @puneetlath
    ContributorAuthor

    All paid. Thanks for the effort everyone! Looking forward to your future contributions 💪🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions