[HOLD for payment 2023-06-19] [$1000] Long-pressing the empty right section of a message with just a link doesn't show correct options.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log into an account on mobile and open a chat.
2. Type a message into the composer that contains only a link e.g. 'google.com', '# google.com', or '> google.com'.
3. Long-press the empty section on the right side of the link to bring up the message's options.

Expected Result:

The options shown in the modal should include, for example, editing the message, deleting the message, replying in a thread, etc.

Actual Result:

The only option shown is to copy the link to the clipboard.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

expensify-link-message-bug.mov

az_recorder_20230531_233139.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Victor-Nyagudi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685357040272429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0178d9eb714da9b983
• Upwork Job ID: 1664225537139695616
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue

The copy to clipboard options shows when clicking on a reportAction with a link even outside the link text instead of the normal context menu.

What is the root cause of that problem?

The root cause is a disparity between web and native platforms as how they render AnchorRender component width.
By default on native, the parent view stretches to cover all the space available for the content but that is not true on web. That's why we see it working correctly on web.

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

Lines 89 to 94 in 9fa12f3

	return (
	<AnchorForCommentsOnly
	href={attrHref}
	// Unless otherwise specified open all links in
	// a new window. On Desktop this means that we will
	// skip the default Save As... download prompt

What changes do you think we should make in order to solve the problem?

The simple solution is to wrap the content returned in AnchorRender with a View having the style alignItems: "flex-start" because this will prevent the View from stretching to the max width and only occupy the size of its content (as mentioned here)
Like this:

<View style={{ alignItems: "flex-start" }}>
  <AnchorForCommentsOnly
     ...
   />
</View>

After applying

Screen.Recording.2023-06-01.at.1.34.58.PM.mov

[Gonals]

Taking a look!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0178d9eb714da9b983

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.