[HOLD for payment 2023-06-23] [$1000] valid html code displays 'this is beginning...' and invalid html code displays weird symbol in LHN for few seconds

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send valid html code. eg:  
4. Observe the message in LHN
5. Send invalid html code. eg: 
6. Observe the message in LHN

Expected Result:

App should display the message as it is in LHN

Actual Result:

App displays 'This is beginning...' message for valid HTML code and weird emoji for invalid HTML code for few seconds in LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

valid.invalid.html.code.lhn.issue.mp4

Recording.804.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685097977437509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0114e290337f545c10
• Upwork Job ID: 1663626267506884608
• Last Price Increase: 2023-05-30

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

valid html code displays 'this is beginning...' and invalid html code displays weird symbol in LHN for few seconds

What is the root cause of that problem?

optimisticReportData has lastMessageText is lastCommentText that is result of formatReportLastMessageText function

App/src/libs/actions/Report.js

Line 213 in 06192ac

const lastCommentText = ReportUtils.formatReportLastMessageText(lastAction.message[0].text);

In formatReportLastMessageText function, we use Str.htmlDecode and trim() to format. With html code  , it is space so that formatReportLastMessageText function returns '' and LHN displays "This is beginning....". With other valid html code, it display decode of that for few second by optimisticReportData, but when API returns data that contains lastMessageText is the correct message user entered instead of html decode of that, that makes LHN displays inconsistent

App/src/libs/ReportUtils.js

Line 643 in 06192ac

return Str.htmlDecode(String(lastMessageText)).replace(CONST.REGEX.AFTER_FIRST_LINE_BREAK, '').substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();

What changes do you think we should make in order to solve the problem?

We should remove Str.htmlDecode in formatReportLastMessageText to be consistent with data from BE and not display "This is beginning..." in LHN for some valid html like  

App/src/libs/ReportUtils.js

Line 643 in 06192ac

return Str.htmlDecode(String(lastMessageText)).replace(CONST.REGEX.AFTER_FIRST_LINE_BREAK, '').substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();

What alternative solutions did you explore? (Optional)

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you send valid html code like  , LHN displays this is beginning ....
When you send invalid html like `�1, LHN displays weird symbol.

What is the root cause of that problem?

The root cause of this issue is in the following function
https://github.com/s-alves10/App/blob/95efb234dc6d9c14d01fa7ffafb2c3d90bfd82f7/src/libs/ReportUtils.js#L642-L644

We decode the lastMessageText first and add some processing to it. But lastMessageText was already decoded text as you can see from where the above function is used.

Double decoding is the main reason.

What changes do you think we should make in order to solve the problem?

Simply removing the decoding part in the function would solve the issue.

function formatReportLastMessageText(lastMessageText) {
    return String(lastMessageText).replace(CONST.REGEX.AFTER_FIRST_LINE_BREAK, '').substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();
}

This works perfectly.

This issue is similar to issue 19539. Both issues can be solved in a PR

Result

mac_chrome_19789.1.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0114e290337f545c10

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @stitesExpensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.