Repository navigation
[HOLD for payment 2024-06-13] [$1000] Chat - Thread - Keyboard does not open when click of reply in thread #19558
Description
Activity
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Looks like we don't auto focus when we open a chat anymore.
@tjferriss Huh... This is 4 days overdue. Who can take care of this?
- changed the title
[-]Chat - Thread - Keyboard does not open when click of reply in thread[/-][+][$1000] Chat - Thread - Keyboard does not open when click of reply in thread[/+]on May 30, 2023 Job added to Upwork: https://www.upwork.com/jobs/~01bb2845ef5dc4bb85
Triggered auto assignment to @anmurali (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)225 remaining items
- changed the title
[-][$1000] Chat - Thread - Keyboard does not open when click of reply in thread[/-][+][HOLD for payment 2024-06-13] [$1000] Chat - Thread - Keyboard does not open when click of reply in thread[/+]on Jun 6, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-13. 🎊
For reference, here are some details about the assignees on this issue:
- @mollfpr requires payment through NewDot Manual Requests
- @bernhardoj requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
- [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@mollfpr] Determine if we should create a regression test for this bug.
- [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:No offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- Open a chat with an existing message
- Verify the composer (if android/iOS/mWeb) isn't focused (if web/desktop) is focused
- Send a message
- Reply in a thread of the message
- Verify the composer is focused and a keyboard is shown for mobile devices (except mWeb Safari because of this [$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414)
- 👍 or 👎
@adelekennedy Could you give the payment summary? Thank you!
Reacted by adelekennedyPayment Summary
- Reviewer: @mollfpr owed $1000 via NewDot
- ROLE: @bernhardoj paid $1000 via Upwork (LINK)
BugZero Checklist (@adelekennedy)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1663649941210693632/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
Ugh - Upwork won't let me reuse the original job posting so I've just created a new job and sent an offer to @bernhardoj
Payouts due:
- Contributor: $1000 @bernhardoj (Upwork)
- Contributor+: $1000 @mollfpr (NewDot)
Upwork job is here.
Accepted
Reacted by adelekennedy$1,000 approved for @mollfpr
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Keyboard opens when click of reply in thread
Actual Result:
Keyboard does not open when click of reply in thread
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.17.2
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20230519_085144_Chrome.mp4
Screen_Recording_20230524_170020_New.Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: Manan Gadhiya (non GH)
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684466830344199
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @adelekennedy