[HOLD for payment 2023-06-13] [$1000] Reply text is not aligned to emoji on edit message (aligned properly without edit)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Hover on any message send by you, click on reply in thread and add new message in it
4. Revisit the original report and add emoji reaction to it (observe that emoji reaction and '1 Reply' message is aligned vertically)
5. Edit the parent message used in step 3 and observe that '1 Reply' message is not aligned to composer start as emoji reaction

Expected Result:

App should align '1 Reply' text to start of composer on edit as it does for reaction emoji

Actual Result:

App does not align '1 Reply' text to start of composer on edit of message as it does for reaction emoji

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

not.aligned.reply.text.on.edit.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684486648715929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0145a755aa7c56d944
• Upwork Job ID: 1661335016989315072
• Last Price Increase: 2023-05-24

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Reply text is not aligned to emoji on edit message (aligned properly without edit)

What is the root cause of that problem?

• The root cause is we have not adjusted styling if we have edit mode (draftMessage) on and we need to adjust styling for margin-left same as we did on the ReportActionItemReactions

What changes do you think we should make in order to solve the problem?

• On ReportActionItem.js on we need to wrap with a <ReportActionItemThread> with the same <View> with styling used of <ReportActionItemReactions> which is this.props.draftMessage ? styles.chatItemReactionsDraftRight : {}

• We can also pass draft props to <ReportActionItemThread> and handle style there

Result

[sonialiap]

Reproducible 👍

Screen.Recording.2023-05-24.at.1.39.02.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0145a755aa7c56d944

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)