[HOLD for payment 2023-06-19] [$1000] Workspace settings page can be opened by any non-admin member of the workspace

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login as user A and create a workspace.
2. Add user B as a member to the workspace.
3. Go to Workspace General Settings and copy the URL for the workspace.
4. Login as user B and open the link you copied previously.

Expected Result:

Not found or Permission denied error should be shown

Actual Result:

The workspace settings page open and allows the user to see / interact with all the forms.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-14.at.3.26.19.AM.mov

Recording.606.mp4

Expensify/Expensify Issue URL:
Issue reported by: @allroundexperts
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684016823040309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a823356a32c5600
• Upwork Job ID: 1659230141558759424
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace Settings page is visible even if you're not an owner / admin of it.

What is the root cause of that problem?

The root cause of the issue is that we have no such check that validates the ownership in the SettingsPage.

What changes do you think we should make in order to solve the problem?

We need to check if the user has appropriate permissions in the Workspace setting pages.

One such check can be added here:

   shouldShow={_.isEmpty(this.props.policy) || !Policy.isPolicyOwner(this.props.policy)}

If we need to show it for the admin instead of the owner, then we can add the following:

   shouldShow={_.isEmpty(this.props.policy) || !Policy.isAdminOfFreePolicy([this.props.policy])}

This check applies to all the workspace pages such as Travel, Reimburse, Card, Bills and Settings page.

If we need to apply this to some of these pages, then we can move the above check to the individual pages. I think it makes more sense to add it to all the Workspace settings pages.

What alternative solutions did you explore? (Optional)

We can also redirect the user to another page on encountering this.
Same statement as above can be checked for and if its true we can use Navigation.navigate function to redirect user to the home screen / workspace page / concierge chat.

[sonialiap]

will triage tomorrow

[sonialiap]

https://staging.new.expensify.com/workspace/90F7140C34753F91/settings

I can confirm the behavior

1. Login as user A and create a workspace.
2. Add user B as a member to the workspace.
3. Go to workspace settings and copy the URL for the workspace
4. Login as user B and open the link you copied previously

Expected result: a member of the workspace that is not an admin should not be able to access that workspace's settings. However, instead of the suggested result of throwing an error, I think we should simply redirect the URL to new.expensify.com.

Actual result: following the URL copied and shared by user A allows user B to access A's workspace settings (but doesn't seem to allow B to change anything).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a823356a32c5600

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.